Skip to content

Add node v16 to ci matrix, and remove v10#640

Merged
pinheadmz merged 2 commits intohandshake-org:masterfrom
Anunayj:node-16-ci
Oct 25, 2021
Merged

Add node v16 to ci matrix, and remove v10#640
pinheadmz merged 2 commits intohandshake-org:masterfrom
Anunayj:node-16-ci

Conversation

@Anunayj
Copy link
Copy Markdown
Contributor

@Anunayj Anunayj commented Oct 2, 2021

Node v10 reached it's EOL on 30-Apr-2021, and therefore i don't
see a need for running ci on that, v16 would soon be the LTS
version (from 26-Oct-2021) therefore needs to be tested on.

Node v10 reached it's EOL on 30-Apr-2021, and therefore i don't
see a need for running ci on that, v16 would soon be the LTS
version (from 26-Oct-2021) therefore needs to be tested on.
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 22, 2021

Pull Request Test Coverage Report for Build 1382817197

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 62.248%

Files with Coverage Reduction New Missed Lines %
lib/protocol/consensus.js 1 82.79%
Totals Coverage Status
Change from base Build 1368460091: 0.002%
Covered Lines: 21189
Relevant Lines: 31820

💛 - Coveralls

@pinheadmz
Copy link
Copy Markdown
Member

Saving this output before adding more tests to the matrix on this branch:

@github-actions
Build / build (12.x) (pull_request) Successful in 3m
Details
@github-actions
Build / build (14.x) (pull_request) Successful in 4m
Details
@github-actions
Build / build (16.x) (pull_request) Successful in 3m
Details

@pinheadmz
Copy link
Copy Markdown
Member

@Anunayj Ok I'm down for this, makes sense. We should also probably then bump the "minimum node version" wherever that is currently documented, like here: https://github.com/handshake-org/hsd#install

@Anunayj
Copy link
Copy Markdown
Contributor Author

Anunayj commented Oct 23, 2021

I think that is the only place that mentions the node version hsd-dev.org redirects to the readme too.

@pinheadmz pinheadmz merged commit 37731e6 into handshake-org:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants