Add node v16 to ci matrix, and remove v10#640
Merged
pinheadmz merged 2 commits intohandshake-org:masterfrom Oct 25, 2021
Merged
Add node v16 to ci matrix, and remove v10#640pinheadmz merged 2 commits intohandshake-org:masterfrom
pinheadmz merged 2 commits intohandshake-org:masterfrom
Conversation
Node v10 reached it's EOL on 30-Apr-2021, and therefore i don't see a need for running ci on that, v16 would soon be the LTS version (from 26-Oct-2021) therefore needs to be tested on.
Pull Request Test Coverage Report for Build 1382817197
💛 - Coveralls |
Member
|
Saving this output before adding more tests to the matrix on this branch: |
Member
|
@Anunayj Ok I'm down for this, makes sense. We should also probably then bump the "minimum node version" wherever that is currently documented, like here: https://github.com/handshake-org/hsd#install |
Contributor
Author
|
I think that is the only place that mentions the node version hsd-dev.org redirects to the readme too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node v10 reached it's EOL on 30-Apr-2021, and therefore i don't
see a need for running ci on that, v16 would soon be the LTS
version (from 26-Oct-2021) therefore needs to be tested on.