Skip to content

fix: remove edge on operation only if it exists #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sequba merged 2 commits into from
May 18, 2025
Merged

fix: remove edge on operation only if it exists #1507

sequba merged 2 commits into from
May 18, 2025

Conversation

@jbmolle
Copy link
Contributor

@jbmolle jbmolle commented May 15, 2025 •
edited
Loading

Context

A formula that includes the same Named Reference more than once throws an error of "Edge does not exist".
This pull request fixes that by not removing the edge on the global id more than once.

How did you test your changes?

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Using a Named Reference more than once in the same formula throws an "Edge does not exist" error #1102
  2. If we're using a Name Reference multiple times, the corresponding global Id edge on the graph is removed only once

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

sequba and others added 2 commits January 15, 2025 16:59
@sequba
Merge develop to master to deploy documentation and fix handsontable#…
469c9dd 
…1480 and handsontable#1481 (handsontable#1487)

* Fix registerLanguage() issue in the code examples (handsontable#1484)

Make code examples check for registered languages before registering new ones

* Fix mortgage calculator demo error `Cannot load native addon because loading addons is disabled` (handsontable#1486)

Migrate mortgage-calculator demo in readme from Codestandbox to Stackblitz
@jbmolle
fix: remove edge on operation only if it exists
af0a6a5
@AMBudnik
Copy link
Contributor

AMBudnik commented May 16, 2025

Thank you very much for taking the time to create a pull request and sign our CLA.

@AMBudnik AMBudnik added the CLA signed Required for PR label May 16, 2025
@sequba sequba changed the base branch from develop to feature/issue-1102 May 18, 2025 14:00
@sequba
Copy link
Contributor

sequba commented May 18, 2025

@jbmolle Thank you for this pull request. It indeed solves issue #1102. Merging.

@sequba sequba merged commit 4ac9979 into handsontable:feature/issue-1102 May 18, 2025
2 checks passed
@sequba sequba mentioned this pull request May 18, 2025
Merged
13 tasks
sequba added a commit that referenced this pull request May 18, 2025
@sequba @jbmolle
Fixed Edge does not exist error when a named expression is used twi…
2fd65dd 
…ce in the same formula. (#1508)

* Add unit test for issue #1102

* Add changelog entry

* fix: remove edge on operation only if it exists (#1507)

---------

Co-authored-by: jbmolle <jbmolle@hotmail.com>
@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 11, 2025

Hi @jbmolle

The corresponding issue is solved and launched under HyperFormula v3.0.1.

I appreciate your help!

mountEvarus pushed a commit to Stellar-Fusion/hyperformula that referenced this pull request Sep 16, 2025
@sequba @jbmolle @mountEvarus
Fixed Edge does not exist error when a named expression is used twi…
b2f019c 
…ce in the same formula. (handsontable#1508)

* Add unit test for issue handsontable#1102

* Add changelog entry

* fix: remove edge on operation only if it exists (handsontable#1507)

---------

Co-authored-by: jbmolle <jbmolle@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA signed Required for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jbmolle @AMBudnik @sequba @Wojciech-Swiderski