Skip to content

Conversation

@sequba
Copy link
Contributor

@sequba sequba commented Jan 13, 2026

Context

Implements the Excel-compatible N function that converts a value to a number.

Input Returns
Number The number itself
Date Serial number
TRUE 1
FALSE 0
Error The error (propagated)
Text, empty, other 0
Range N of first cell

Changes:

  • Implementation: Added N function to TextPlugin (alongside related T function)
  • Translations: Added for all 17 supported languages (N, Ч, NUM, TAL, S)
  • Documentation: Added to built-in functions list
  • Tests: 19 unit tests covering all value types, edge cases, and error handling

How did you test your changes?

all unit tests pass, including 19 new unit tests

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Function N #1585

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Jan 13, 2026
@sequba sequba requested a review from budnix January 13, 2026 15:41
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Performance comparison of head (87d6246) vs base (f706d17)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 510.81 | 509.39 | -0.28%
                                      Sheet B | 169.69 | 167.88 | -1.07%
                                      Sheet T | 149.35 | 146.99 | -1.58%
                                Column ranges | 497.89 | 500.04 | +0.43%
Sheet A:  change value, add/remove row/column |  14.48 |  14.05 | -2.97%
 Sheet B: change value, add/remove row/column | 133.32 | 134.04 | +0.54%
                   Column ranges - add column |  147.4 | 142.41 | -3.39%
                Column ranges - without batch | 443.95 | 435.19 | -1.97%
                        Column ranges - batch | 118.09 | 119.34 | +1.06%

@sequba sequba merged commit a1fb600 into develop Jan 14, 2026
31 checks passed
@sequba sequba deleted the feature/issue-1585 branch January 14, 2026 09:28
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.18%. Comparing base (f706d17) to head (87d6246).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1606   +/-   ##
========================================
  Coverage    97.17%   97.18%           
========================================
  Files          170      170           
  Lines        14785    14796   +11     
  Branches      3245     3250    +5     
========================================
+ Hits         14368    14379   +11     
  Misses         409      409           
  Partials         8        8           
Files with missing lines Coverage Δ
src/i18n/languages/csCZ.ts 100.00% <ø> (ø)
src/i18n/languages/daDK.ts 100.00% <ø> (ø)
src/i18n/languages/deDE.ts 100.00% <ø> (ø)
src/i18n/languages/enGB.ts 100.00% <ø> (ø)
src/i18n/languages/esES.ts 100.00% <ø> (ø)
src/i18n/languages/fiFI.ts 100.00% <ø> (ø)
src/i18n/languages/frFR.ts 100.00% <ø> (ø)
src/i18n/languages/huHU.ts 100.00% <ø> (ø)
src/i18n/languages/itIT.ts 100.00% <ø> (ø)
src/i18n/languages/nbNO.ts 100.00% <ø> (ø)
... and 7 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants