Fetch hyperformula-tests before running linter#1672
Merged
Conversation
✅ Deploy Preview for hyperformula-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1672 +/- ##
========================================
Coverage 97.16% 97.16%
========================================
Files 175 175
Lines 15319 15319
Branches 3287 3287
========================================
Hits 14884 14884
Misses 435 435 🚀 New features to boost your workflow:
|
Performance comparison of head (c5dc295) vs base (1b6767f) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lint GitHub Action did not check out the
hyperformula-testsrepository before running ESLint. As a result, lint errors inside files undertest/hyperformula-tests/were silently skipped in CI and only surfaced when runningnpm run lintlocally.This PR aligns
.github/workflows/lint.ymlwith.github/workflows/test.ymlso the linter sees the same source tree as the test jobs.Changes
.github/workflows/lint.ymlCheckout hyperformula-tests repositorystep (usingDEPLOY_TOKEN, target pathtest/hyperformula-tests).Fetch hyperformula-tests and sync branchesstep runningtest/fetch-tests.sh.test.yml.