Skip to content

Conversation

@m1ga
Copy link
Collaborator

@m1ga m1ga commented Aug 26, 2021

Update Crashlytics dependencies.
Issue found (see 2nd post)

var crash = require("ti.crashlytics");
crash.crash()

@m1ga
Copy link
Collaborator Author

m1ga commented Aug 26, 2021

Looks like an issue in the current SDK: firebase/firebase-android-sdk#1944 (comment)
I've added an init() method that you need to run on Android.

@m1ga m1ga changed the title WIP: [Update] Android dependencies [Update] Android dependencies Aug 27, 2021
@m1ga
Copy link
Collaborator Author

m1ga commented Aug 27, 2021

#36 is fixed since the custom <string> is not needed now.

tested and crashes appear in Firebase console. Can be merged @hansemannn

@macasfaj
Copy link

I’ve tested. It works like a charm. Thanks @m1ga 👏🏻👏🏻

@hansemannn
Copy link
Owner

@m1ga Would it be possible to place this in onCreate like suggested by him? I think there is a override method for that!

@m1ga
Copy link
Collaborator Author

m1ga commented Aug 28, 2021

@hansemannn I'll check it again 👍 I've tried onAppCreate before but it could be that it was a configuration issue at the time I've tried that. Now I know it should work so let me try it again. Of course that would be easier to use

@m1ga
Copy link
Collaborator Author

m1ga commented Aug 31, 2021

onAppCreate() worked! Removed the init() part again. So now its a simple module update for existing users.

ti.crashlytics-android-2.1.0.zip

@hansemannn hansemannn merged commit b13ca24 into hansemannn:master Aug 31, 2021
@hansemannn
Copy link
Owner

Thanks @m1ga, this is great! Can you draft a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants