fix(release): correct PYPI_TOKEN error message in check-release-environment#31
Merged
hanzo-dev merged 1 commit intoJun 2, 2026
Conversation
…onment The script checks for the PYPI_TOKEN env var, but the error message only mentioned HANZO_PYPI_TOKEN. CI workflows actually map either the HANZO_PYPI_TOKEN or PYPI_TOKEN secret into PYPI_TOKEN (see .github/workflows/publish-pypi.yml and release-doctor.yml), so the message was misleading when the variable was missing. Update the text to match the real behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
bin/check-release-environmentguards the release flow by checking thatPYPI_TOKENis set, but the error message it prints only mentionsHANZO_PYPI_TOKEN. The CI workflows (.github/workflows/publish-pypi.yml,release-doctor.yml,hanzo-packages-ci.yml, etc.) map eitherHANZO_PYPI_TOKENorPYPI_TOKENinto thePYPI_TOKENenv var, so the existing message is misleading when the variable is missing — a maintainer setting onlyPYPI_TOKENwould still see a complaint aboutHANZO_PYPI_TOKEN.This 1-line change updates the message to describe what is actually checked and what secrets can satisfy it. No logic change.