Skip to content

Conversation

@ShreejithSG
Copy link
Collaborator

  • Move LoRA extraction README to docs/utilities/lora.md
  • Add Utilities section to navigation in mkdocs.yml
  • Update script paths to use full scripts/lora_extraction/ prefix

- Move LoRA extraction README to docs/utilities/lora.md
- Add Utilities section to navigation in mkdocs.yml
- Update script paths to use full scripts/lora_extraction/ prefix
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ShreejithSG, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's documentation by introducing a dedicated section for LoRA (Low-Rank Adaptation) extraction and merging utilities. The change aims to provide clear, accessible instructions for users working with these tools, improving the overall usability and discoverability of these important functionalities within the FastVideo ecosystem.

Highlights

  • New LoRA Utilities Documentation: A new documentation page has been added under docs/utilities/lora.md detailing the usage of LoRA extraction and merging utilities for FastVideo models.
  • Navigation Update: The mkdocs.yml configuration has been updated to include a new 'Utilities' section in the navigation, making the LoRA documentation easily discoverable.
  • Script Path Standardization: The documentation now uses full script paths (e.g., scripts/lora_extraction/extract_lora.py) for clarity and consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively documents the LoRA extraction utilities by migrating a README file into the official documentation and updating script paths. The new documentation is a valuable addition. I've provided a couple of minor suggestions on the new markdown file to enhance clarity and correct a potential typo in an example command. Overall, this is a good contribution to the project's documentation.

- `--base`: Base model (HuggingFace ID or local path)
- `--ft`: Fine-tuned model (HuggingFace ID or local path)
- `--out`: Output adapter file
- `--rank`: LoRA rank (16, 32, 64, 128)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description for the --rank option is a bit restrictive. The script allows any integer value, and values less than or equal to zero are used to indicate full rank (similar to the --full-rank flag). The documentation should reflect this flexibility for better user understanding.

Suggested change
- `--rank`: LoRA rank (16, 32, 64, 128)
- `--rank`: LoRA rank (e.g., 16, 32, 64, 128). Values <= 0 will use full rank.

--prompt "A cat sitting on a windowsill" \
--seed 42 \
--height 480 \
--width 480 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The example command for quality validation sets --width 480, while the default value for this parameter is 832. This appears to be a typo, likely copied from the --height parameter. To prevent user confusion, I recommend updating this to a more representative value, such as the default.

Suggested change
--width 480 \
--width 832 \

@SolitaryThinker SolitaryThinker changed the title docs: add LoRA extraction utilities documentation [docs]: add LoRA extraction utilities documentation Jan 6, 2026
@SolitaryThinker SolitaryThinker merged commit d9c9963 into hao-ai-lab:main Jan 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants