-
Notifications
You must be signed in to change notification settings - Fork 244
[docs]: add LoRA extraction utilities documentation #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: add LoRA extraction utilities documentation #992
Conversation
ShreejithSG
commented
Jan 5, 2026
- Move LoRA extraction README to docs/utilities/lora.md
- Add Utilities section to navigation in mkdocs.yml
- Update script paths to use full scripts/lora_extraction/ prefix
- Move LoRA extraction README to docs/utilities/lora.md - Add Utilities section to navigation in mkdocs.yml - Update script paths to use full scripts/lora_extraction/ prefix
Summary of ChangesHello @ShreejithSG, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's documentation by introducing a dedicated section for LoRA (Low-Rank Adaptation) extraction and merging utilities. The change aims to provide clear, accessible instructions for users working with these tools, improving the overall usability and discoverability of these important functionalities within the FastVideo ecosystem. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively documents the LoRA extraction utilities by migrating a README file into the official documentation and updating script paths. The new documentation is a valuable addition. I've provided a couple of minor suggestions on the new markdown file to enhance clarity and correct a potential typo in an example command. Overall, this is a good contribution to the project's documentation.
| - `--base`: Base model (HuggingFace ID or local path) | ||
| - `--ft`: Fine-tuned model (HuggingFace ID or local path) | ||
| - `--out`: Output adapter file | ||
| - `--rank`: LoRA rank (16, 32, 64, 128) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for the --rank option is a bit restrictive. The script allows any integer value, and values less than or equal to zero are used to indicate full rank (similar to the --full-rank flag). The documentation should reflect this flexibility for better user understanding.
| - `--rank`: LoRA rank (16, 32, 64, 128) | |
| - `--rank`: LoRA rank (e.g., 16, 32, 64, 128). Values <= 0 will use full rank. |
| --prompt "A cat sitting on a windowsill" \ | ||
| --seed 42 \ | ||
| --height 480 \ | ||
| --width 480 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example command for quality validation sets --width 480, while the default value for this parameter is 832. This appears to be a typo, likely copied from the --height parameter. To prevent user confusion, I recommend updating this to a more representative value, such as the default.
| --width 480 \ | |
| --width 832 \ |