Route shadowing

[aymericbeaumet]

It seems Hapi does route shadowing. Is it on purpose?

Considering the example below, the /foo/bar route will never be reached (404).

'use strict';

var Hapi = require('hapi');

var server = new Hapi.Server('localhost', 8080);
server.route(
  { method: 'GET', path: '/foo', handler: handler },
  { method: 'GET', path: '/foo/bar', handler: handler }
);
server.start();

function handler(request, reply) {
  return reply(request.path);
}

[Marsup]

It doesn't do shadowing, you're supposed to provide multiple routes in an array, not several parameters, it bit me several times.
For routes priorities you can refer to http://hapijs.com/api#path-processing.

[aymericbeaumet]

Indeed passing routes as an array works.

server.route([
  { method: 'GET', path: '/foo', handler: handler },
  { method: 'GET', path: '/foo/bar', handler: handler }
]);

The link you gave me to the documentation is however not appropriate. I am not looking to declare several paths for a single route :)

Thanks

[hueniverse]

Is this really an issue that we should slice the arguments and turn them into an array?

[Marsup]

I've seen people make the same mistake and it wouldn't be a huge change to support, but avoid slice, it causes deopt in v8.

[hueniverse]

I added an assert for now.

[aymericbeaumet]

The thing is the documentation does not explicitly say it's possible to pass several routes as an array.
Edit: my bad.

IMO you guys should either throw an explicit error or make server.route behave as a variadic function.

@Marsup Do we really have to worry about a deopt happening a single time at the app configuration?

[Marsup]

It's not a hot path but it doesn't happen a single time for most people. If you know about it better avoid it.

[Rob-pw]

The relevant documentation appears to have moved: https://hapijs.com/api#path-matching-order.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.