Send correct response for HEAD requests#3179
Merged
Merged
Conversation
cf6b744 to
60f77a3
Compare
Contributor
Author
|
Rebased to latest master. Any chance you could look into this? It's a bit unfortunate that Also, what happened to the travis integration? |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that a
HEADrequest for some of my routes did not send thecontent-lengthheader, while a normalGETrequest would. I have updated the logic to properly set the header. This is done by not skipping the marshal step.This also fixes specific cases where the
content-typeheader could be different forGETandHEADif it is set during or post marshaling.FYI, the modified and new test both fail on current master as follows: