Update invalid path test to match message#4259
Closed
arafel wants to merge 1 commit intohapijs:masterfrom
arafel:invalid_request_test
Closed
Update invalid path test to match message#4259arafel wants to merge 1 commit intohapijs:masterfrom arafel:invalid_request_test
arafel wants to merge 1 commit intohapijs:masterfrom
arafel:invalid_request_test
Conversation
Contributor
|
Thanks, but this is already handled in the pending PR #4258. |
Contributor
Contributor
|
Wow, wrong link yeah |
Author
|
Thanks both. I have to confess it didn’t occur to me that was a Node change - no wonder all the commits I tested failed. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed on running the tests that 'returns 400 on invalid path' (currently test 392) fails because of a text mismatch. I checked back to at least v20.0.3 and it failed in the same way. The text of the test hasn't changed since 2018.
I wasn't able to find out where the text is generated, unfortunately, but took a guess that the new text is okay. If someone can point me to where the error text comes from I'm happy to look again. :-)
Thanks
Paul