Plug few isolated memleaks that showed up during profiling#581
Merged
DimCitus merged 3 commits intohapostgres:masterfrom Feb 5, 2021
Merged
Plug few isolated memleaks that showed up during profiling#581DimCitus merged 3 commits intohapostgres:masterfrom
DimCitus merged 3 commits intohapostgres:masterfrom
Conversation
DimCitus
requested changes
Feb 5, 2021
Collaborator
DimCitus
left a comment
DimCitus
left a comment
There was a problem hiding this comment.
Thanks for the clean-up job Georgios, that's highly appreciated! I think we should simply the free management in get_pgpid (free once when we know we don't use the contents directly anymore), and I wonder if we should pre-allocate the strVal in SingleValueResultContext though I would understand if we want to make that another PR.
gkokolatos
force-pushed
the
pg_autoctl-memcheck
branch
from
0632742 to
2ab4c2a
Compare
DimCitus
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it says on the tin + what it seems to be a missing return in
pg_setup_get_local_connection_string