Relax the checks/assertions on which PID owns the semaphore#822
Merged
Relax the checks/assertions on which PID owns the semaphore#822
Conversation
It turns out that the checks to ensure which PID owns the semaphore is too aggressive. The PID might be 0, pid of our own process or any process above to our PID in the process tree. So, we simplify the rule. We only terminate the semaphore when we are owner of the PID. Else, we wait until the owner of the PID exits (which will eventually happen).
DimCitus
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the checks to ensure which PID owns the semaphore
is too aggressive. The PID might be 0, pid of our own process or
any process above to our PID in the process tree.
So, we simplify the rule. We only terminate the semaphore when
we are owner of the PID. Else, we wait until the owner of the
PID exits (which will eventually happen).