Implement make compose, using docker-compose for local interactive testing.#825
Merged
Implement make compose, using docker-compose for local interactive testing.#825
Conversation
DimCitus
added
Size: S
DimCitus
added
Size:M
Contributor
|
Hi! I took a look at this on a MacOS. I like how easy is has become to run the tests against different versions of postgres. :)
Testing now! I needed to re-compile This is very cool! I like how you've added the helper text after the system is set up. |
DimCitus
force-pushed
the
dx/add-pgversion-to-dockerfile
branch
from
8f9877e to
797628d
Compare
DimCitus
force-pushed
the
dx/add-pgversion-to-dockerfile
branch
3 times, most recently
from
0cadeaf to
5171f91
Compare
DimCitus
force-pushed
the
dx/add-pgversion-to-dockerfile
branch
3 times, most recently
from
f7abd32 to
18349b8
Compare
DimCitus
force-pushed
the
dx/add-pgversion-to-dockerfile
branch
from
18349b8 to
652e7d8
Compare
DimCitus
changed the title
JelteF
approved these changes
Dec 23, 2021
Similar to `make cluster`, this allows to start a local cluster to play with multiple Postgres nodes registered in a pg_auto_failover monitor. This time the command uses docker-compose to run all the nodes in the background, and each node has its own pre-created external docker volume.
DimCitus
force-pushed
the
dx/add-pgversion-to-dockerfile
branch
from
6e16d97 to
9f006f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
make composecommand that works the same way as themake clustercommand, though usesdocker-composeto start the monitor and the Postgres nodes in a way that uses a single tmux pane.When using
make composeit is possible to use PGVERSION to test with a specific docker image, such as e.g. in the commandmake PGVERSION=13 NODES=6 NODES_ASYNC=3 NODES_PRIOS=50,50,50,0 compose.Be sure to run the usual build and also
make build build-checkfirst, that should clean-up the local docker images you might have dangling, and hopefully make everything just work.