Skip to content

Dx/fix dockerfile for pgversions#855

Merged
DimCitus merged 4 commits intomasterfrom
dx/fix-dockerfile-for-pgversions
Dec 15, 2021
Merged

Dx/fix dockerfile for pgversions#855
DimCitus merged 4 commits intomasterfrom
dx/fix-dockerfile-for-pgversions

Conversation

@DimCitus
Copy link
Copy Markdown
Collaborator

Just the Dockerfile and Makefile changes this time.

That way we can easily build and test pg_auto_failover locally with any
supported version of Postgres. We use docker build --build-arg for that, and
split the Dockerfile in more stages for clarity and better cache re-use.

It is now possible to run the same test for Postgres 10 then 14 that way:

    $ make run-test TEST=test_auth PGVERSION=10
    $ make run-test TEST=test_auth PGVERSION=14
@DimCitus DimCitus added enhancement New feature or request Size: S Effort Estimate: Small Developer productivity Enhancements to ability to ship quality code labels Dec 15, 2021
@DimCitus DimCitus requested review from JelteF and thanodnl December 15, 2021 14:04
@DimCitus DimCitus self-assigned this Dec 15, 2021
@DimCitus DimCitus merged commit f174e9e into master Dec 15, 2021
@DimCitus DimCitus deleted the dx/fix-dockerfile-for-pgversions branch December 15, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Developer productivity Enhancements to ability to ship quality code enhancement New feature or request Size: S Effort Estimate: Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants