Updated README to use '--formation monitor'.#880
Merged
DimCitus merged 3 commits intohapostgres:masterfrom May 30, 2022
Merged
Conversation
… README to use '--formation monitor' hapostgres#874.
|
|
DimCitus
requested changes
May 2, 2022
Collaborator
DimCitus
left a comment
DimCitus
left a comment
There was a problem hiding this comment.
Thanks for the PR! I believe the code editing wasn't necessary, even though the current help string and docs might be misleading.
|
|
||
| static struct option long_options[] = { | ||
| { "pgdata", required_argument, NULL, 'D' }, | ||
| { "monitor", required_argument, NULL, 'm' }, |
Collaborator
There was a problem hiding this comment.
Do we really want to remove the --monitor option from the command? It should be possible still to do the following:
$ pg_autoctl show uri --monitor postgres://monitor:5432/pg_auto_failover --formation foo
I suppose it's only documentation that should be updated.
Contributor
Author
There was a problem hiding this comment.
Alright, --monitor option has been put back.
chewygranola
changed the title
chewygranola
changed the title
DimCitus
approved these changes
May 30, 2022
DimCitus
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… README to use '--formation monitor' #874.