Skip to content

Do not use poetry2nix to build esctl.#21

Merged
aevox merged 2 commits intomasterfrom
nix-build
Oct 15, 2025
Merged

Do not use poetry2nix to build esctl.#21
aevox merged 2 commits intomasterfrom
nix-build

Conversation

@aevox
Copy link
Copy Markdown
Contributor

@aevox aevox commented Oct 13, 2025

Poetry2nix is not maintained anymore. We use a more native approach to build esctl. This requires to "downgrade" the requirements of some libraries.

@aevox aevox requested a review from a team as a code owner October 13, 2025 14:22
@aevox aevox added the team/ops PRs assigned to happn-app/ops team label Oct 13, 2025
Poetry2nix is not maintained anymore. We use a more native approach to
build esctl. This requires to "downgrade" the requirements of some
libraries.
@aevox aevox added the component/ci For PRs that update the CI label Oct 13, 2025
@aevox aevox force-pushed the nix-build branch 3 times, most recently from 1f87126 to aa822c3 Compare October 13, 2025 16:02
@sbordeyne
Copy link
Copy Markdown
Contributor

Instead of downgrading dependencies (which I'm not a fan of, because dependabot will open dozens of PRs to bump them back up), I'd rather switch package managers.

A good contender is uv which I'm not a fan of either (only because it's backed by a for-profit company)

uv has gathered quite a large community of python developers though, and there is a maintained uv2nix project (mentioned in the readme of poetry2nix)

The other reason I'm not a fan of going to a more "native" nix approach here is that it forces 2 sources of truth for the package versions, the flake.nix and the pyproject.toml. People installing from nix and with pipx will also get different versions of the dependencies which is not a problem right now, but feels like it shouldn't happen.

If you want I can migrate the project to be built with uv instead to simplify the writing of the flake.nix file, would that be an acceptable compromise ?

Copy link
Copy Markdown
Contributor

@sbordeyne sbordeyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a temporary fix, while I migrate to yq, it's okay 👍

@aevox aevox enabled auto-merge (squash) October 14, 2025 14:12
@aevox aevox disabled auto-merge October 14, 2025 14:12
@aevox aevox merged commit 7e9061c into master Oct 15, 2025
6 checks passed
@aevox aevox deleted the nix-build branch October 15, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ci For PRs that update the CI team/ops PRs assigned to happn-app/ops team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants