Skip to content

chore(.dev): surface gh pr list errors + checkout main between iterations#54

Merged
jrphilo merged 1 commit into
mainfrom
chore/loop-error-visibility
May 13, 2026
Merged

chore(.dev): surface gh pr list errors + checkout main between iterations#54
jrphilo merged 1 commit into
mainfrom
chore/loop-error-visibility

Conversation

@jrphilo
Copy link
Copy Markdown
Collaborator

@jrphilo jrphilo commented May 13, 2026

Summary

Two small reliability fixes to the dependency loop after first real-run findings:

  1. Surface gh pr list errors. The Phase 2 queue check redirected stderr to /dev/null, so any transient gh failure silently returned empty and the loop printed "Queue empty" instead of the real error. Now captures stderr and exits non-zero on failure with the actual message.
  2. git checkout main between iterations. Defensive — the agent's session usually returns to BASE_BRANCH per the prompt, but if it doesn't (early exit, crash, missed step) the next iteration's gh pr checkout would layer onto stale state.

Motivated by: yesterday's run labeled #44 successfully but reported "Queue empty" despite 7 eligible PRs remaining. Root cause unclear — these two changes will either fix it or surface what's actually happening on the next run.

Test plan

  • bash -n .dev/dependency.sh
  • Run ./.dev/dependency.sh --upgrade-only --max-deps 7 after merge; expect it to attempt all 7 eligible PRs or surface a real error.

🤖 Generated with Claude Code

…ations

The Phase 2 queue check redirected stderr to /dev/null, so any
transient gh failure (rate limit, network blip) silently returned
empty and the loop printed "Queue empty" instead of the real error.
Capture stderr to a temp file, exit non-zero with the real message
when gh fails.

Also: defensively `git checkout main` between iterations. The agent's
session usually returns to BASE_BRANCH per the prompt, but if it
doesn't (early exit, crash) the next iteration's gh pr checkout would
layer onto stale state.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jrphilo jrphilo enabled auto-merge (squash) May 13, 2026 14:16
@jrphilo jrphilo merged commit ecefea9 into main May 13, 2026
7 checks passed
@jrphilo jrphilo deleted the chore/loop-error-visibility branch May 13, 2026 14:17
jrphilo added a commit that referenced this pull request May 13, 2026
Combines #52 and #53 into a single PR off main, avoiding the
rebase cascade after #44/#42/#54/#55 churn. Both are mechanical
pnpm.overrides additions:

- protobufjs ^7.5.6 — clears alerts #7-14
  (GHSA-q6x5-8v7m-xcrf, GHSA-jvwf-75h9-cwgg, GHSA-75px-5xx7-5xc7,
   GHSA-fx83-v9x8-x52w, GHSA-2pr8-phx7-x9h3, GHSA-66ff-xgx4-vchm,
   GHSA-685m-2w69-288q). Reached via posthog-js OTLP exporter;
   not directly imported by our app.

- fast-xml-builder ^1.1.7 — clears alerts #3, #4
  (GHSA-5wm8-gmm8-39j9, GHSA-45c6-75p6-83cc). Reached via
   @opennextjs/cloudflare → AWS SDK build/deploy tooling; not
   directly used.

Replaces #52, #53.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jrphilo added a commit that referenced this pull request May 13, 2026
…er (#57)

Combines #52 and #53 into a single PR off main, avoiding the
rebase cascade after #44/#42/#54/#55 churn. Both are mechanical
pnpm.overrides additions:

- protobufjs ^7.5.6 — clears alerts #7-14
  (GHSA-q6x5-8v7m-xcrf, GHSA-jvwf-75h9-cwgg, GHSA-75px-5xx7-5xc7,
   GHSA-fx83-v9x8-x52w, GHSA-2pr8-phx7-x9h3, GHSA-66ff-xgx4-vchm,
   GHSA-685m-2w69-288q). Reached via posthog-js OTLP exporter;
   not directly imported by our app.

- fast-xml-builder ^1.1.7 — clears alerts #3, #4
  (GHSA-5wm8-gmm8-39j9, GHSA-45c6-75p6-83cc). Reached via
   @opennextjs/cloudflare → AWS SDK build/deploy tooling; not
   directly used.

Replaces #52, #53.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant