Support for bridge v6 and RGBWW bulbs #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for RGBWW saturation
… will no longer be blocked by receiving a response.
| self._group.hue = stage.args[0] | ||
| elif stage.name == 'saturation': | ||
| self._group.saturation = stage.args[0] | ||
| elif stage.name == 'color': |
Owner
There was a problem hiding this comment.
Duplicate of line 156-157.
| return self._build_command(self._offset(0xC5), | ||
| select=True, select_command=self.on()) | ||
|
|
||
| def color(self, color): |
Owner
There was a problem hiding this comment.
This class is missing the hue command as required by limitlessled/group/rgbw.py. This might be an easy fix for you since you're most familiar with the hue stuff.
I will also take a look on my side.
Owner
After trying to set brightness on a legacy white bulb. Btw, the legacy RGBW works great now with the latest commits. |
Collaborator
Author
|
Good to hear that the RGBW bulbs work now :) |
Owner
|
That change prevents the error, but the |
Collaborator
Author
|
I pushed a commit, which should fix this issue. |
Owner
|
Indeed it does. Awesome! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already discussed in #7, this adds support for wifi bridges v6 and RGBWW bulbs. While implementing I also faced some minor issues (especially with the transition logic), which I fixed in general for all bulb types.
I could only test with bridge v6 and RGBWW bulbs, so I cannot guarantee that it works for older bridges or other led types. Therefore, to ensure I didn't break anything, somebody else has to test this. There were also some guys which confirmed that this fork is working in #7 ;)