fix the broken gitactions

[hapticPaper]

review the app packaging and make sure its using the correct files in all builds

-- Deploying dependencies for existing files in AppDir --
Deploying dependencies for ELF file /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/bin/hardclaw
Skipping deployment of blacklisted library /lib/x86_64-linux-gnu/libgcc_s.so.1
Skipping deployment of blacklisted library /lib/x86_64-linux-gnu/libm.so.6
Skipping deployment of blacklisted library /lib/x86_64-linux-gnu/libc.so.6
Deploying dependencies for ELF file /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/bin/hardclaw-cli
Deploying dependencies for ELF file /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/bin/hardclaw-node

-- Copying files into AppDir --
Setting rpath in ELF file /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/bin/hardclaw to $ORIGIN/../lib
Setting rpath in ELF file /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/bin/hardclaw-cli to $ORIGIN/../lib
Setting rpath in ELF file /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/bin/hardclaw-node to $ORIGIN/../lib

-- Deploying icons --
Deploying icon /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/share/icons/hicolor/256x256/apps/hardclaw.png
ERROR: Icon /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/share/icons/hicolor/256x256/apps/hardclaw.png has invalid x resolution: 180
ERROR: Valid resolutions for icons are: 8x8, 16x16, 20x20, 22x22, 24x24, 28x28, 32x32, 36x36, 42x42, 48x48, 64x64, 72x72, 96x96, 128x128, 160x160, 192x192, 256x256, 384x384, 480x480, 512x512
ERROR: Failed to deploy icon: /home/runner/work/hardclaw/hardclaw/dist/AppDir/usr/share/icons/hicolor/256x256/apps/hardclaw.png

[charliecreates]

Expand this to see my work.

• Scanned Cargo.toml to confirm .deb [package.metadata.deb] and RPM [package.metadata.generate-rpm] assets were still wiring docs/assets/apple-touch-icon.png into usr/share/icons/hicolor/256x256/apps/hardclaw.png, matching the historical AppImage error about a 180x180 icon at a 256x256 path.
• Updated Cargo.toml so both the deb and rpm assets entries now use docs/assets/claw-256.png for usr/share/icons/hicolor/256x256/apps/hardclaw.png, keeping the existing favicon-32.png and favicon-16.png mappings for 32x32 and 16x16 icon sizes.
• Ran git diff to verify the only changes are the two asset paths in [package.metadata.deb] and [package.metadata.generate-rpm], with the diff summary showing Cargo.toml | 4 ++-- and no unrelated edits.
• Committed the packaging fix as fix(packaging): use 256px icon for deb/rpm on branch ai-3-fix-the-broken-gitactions, tying the change to the icon-resolution failure described in Issue #3.
• Completed a local CI-style verification stack (cargo fmt --all -- --check, cargo test --all-features, cargo clippy --all-features, cargo build --release, then npm ci && npm run build in hardclaw-mcp), with all commands exiting successfully and no additional AppDir or icon-related errors reported.
• Re-ran cargo test --all-features -q followed by a focused cargo clippy --all-features check, confirming 117/117 tests passing and only 4 existing clippy warnings reported for hardclaw (no new lints introduced by the packaging change).
• Inspected the incidental Cargo.lock diff showing only hardclaw version metadata, a new winres dependency chain, and a toml entry, then reverted it with git checkout -- Cargo.lock to keep the branch strictly limited to Cargo.toml packaging metadata updates.
• Verified with git status --porcelain=v1 that the working tree is now clean aside from the intentional Cargo.toml change, confirming there are no stray lockfile or build-artifact modifications pending.
• Pushed the fix branch to GitHub with git push -u origin ai-3-fix-the-broken-gitactions --force-with-lease, confirming the new branch now tracks origin/ai-3-fix-the-broken-gitactions and is ready for a PR at https://github.com/hapticPaper/hardclaw/pull/new/ai-3-fix-the-broken-gitactions.

[charliecreates]

Opened PR #4 to fix the Linux packaging icon mismatch: .deb/.rpm were installing the 180×180 apple-touch-icon.png as the 256x256 app icon, which is the same class of mistake that triggers the linuxdeploy icon-resolution error shown in this issue.

#4

Note: the failing run in the issue body looks like it came from the tag workflow on v0.10.20 (run https://github.com/hapticPaper/hardclaw/actions/runs/21737108130). Because tag workflows use the workflow + scripts from that tagged commit, re-running that same tag won’t pick up fixes from main; after this lands, the way to get a clean release is to cut a new tag from main.

Changes

• Update Cargo.toml (cargo-deb + cargo-generate-rpm) to install docs/assets/claw-256.png to usr/share/icons/hicolor/256x256/apps/hardclaw.png (instead of docs/assets/apple-touch-icon.png).

Verification

# Rustfmt: clean
cargo fmt --all -- --check

# Rust tests: ok (117 passed)
cargo test --all-features -q

# Clippy: ok (4 warnings)
cargo clippy --all-features

# Release build: success
cargo build --release

# MCP build: success
(cd hardclaw-mcp && npm ci)
(cd hardclaw-mcp && npm run build --silent)

[hapticPaper]

@CharlieHelps, new error:
Run cargo deb --no-build --target x86_64-unknown-linux-gnu
/home/runner/work/hardclaw/hardclaw/target/debian/hardclaw_0.10.22-1_amd64.deb
cp: cannot stat 'target/generate-rpm/*.rpm': No such file or directory
Error: Process completed with exit code 1.

[charliecreates]

Investigating this new packaging error now and I’m likely to review the workflow step that’s copying target/generate-rpm/*.rpm and how the RPM artifacts are produced (or skipped) in the current build.

Updated: Feb 6, 04:36 UTC
I’m working and can’t be interrupted or see replies—feel free to start another task with me while I finish.

[charliecreates]

Expand this to see my work.

• Reviewed .github/workflows/release.yml changes on branch ai-5-fix-rpm-copy-path to ensure the RPM copy step now targets target/${{ matrix.target }}/generate-rpm/*.rpm while leaving .deb handling untouched for issue #3.
• Re-ran cargo fmt --all -- --check && cargo test --all-features -q && cargo clippy --all-features from the repo root to confirm the workflow-only change did not introduce formatting issues, test failures, or new Clippy warnings (all passed with exit code 0).
• Inspected git status and git diff -- Cargo.lock to confirm that local Cargo commands only updated the hardclaw entry (version 0.10.22) and added winres/toml packages, then reverted Cargo.lock to keep this work scoped strictly to the CI workflow.
• Posted a review comment on .github/workflows/release.yml via the code review tool explaining why target/${{ matrix.target }}/generate-rpm/*.rpm matches cargo generate-rpm --target ${{ matrix.target }} output and noting the need to keep matrix.target aligned with Rust target triples.
• Checked recent commits on origin/main with git log -5 --oneline to align the new commit message with existing conventions like fix(packaging): ... and release-tag commits.
• Staged .github/workflows/release.yml and committed the change using git commit -m "fix(ci): copy target-specific RPM artifacts" so the RPM path fix is now ready to push and reference back on issue #3.
• Inspected recent merged PRs via gh pr list --state merged --limit 10 --json=title,body,headRefName,number,labels to mirror the existing style used in PR #4 and PR #2 for the new CI fix PR.
• Opened PR #5 from ai-5-fix-rpm-copy-path to main titled fix(ci): copy target-specific RPM artifacts with a body that documents the RPM path bug, the .github/workflows/release.yml change, and the cargo fmt/cargo test/cargo clippy verification results, and links it back to issue #3.
• Confirmed a clean working tree with git status --porcelain=v1 after creating PR #5 to ensure no stray changes beyond the workflow update.
• Added CharlieHelps as a reviewer on PR #5 so the RPM artifact fix is explicitly tracked and reviewable alongside the new error reported in issue #3.

[charliecreates]

#3 (comment)

That cp: cannot stat 'target/generate-rpm/*.rpm' happens because the workflow runs cargo generate-rpm --target ${{ matrix.target }}, and with --target the RPM ends up under target/<target-triple>/generate-rpm/ (for example target/x86_64-unknown-linux-gnu/generate-rpm/), not target/generate-rpm/.

I opened PR #5 to fix the copy path in .github/workflows/release.yml: #5

Once that’s merged, you’ll need a new tag (the failing tag’s workflow is “locked” to the old commit, so re-running the same tag won’t pick up the fix).

Verification

# Rustfmt: clean
$ cargo fmt --all -- --check

# Rust tests: ok (117 passed)
$ cargo test --all-features -q

# Clippy: ok (4 warnings)
$ cargo clippy --all-features

Skipped rebuilding hardclaw-mcp since the change is isolated to the GitHub Actions workflow.