Fully initialize usb2can Bus interface object.#501
Merged
hardbyte merged 3 commits intohardbyte:developfrom Feb 13, 2019
Merged
Fully initialize usb2can Bus interface object.#501hardbyte merged 3 commits intohardbyte:developfrom
hardbyte merged 3 commits intohardbyte:developfrom
Conversation
The usb2can interface backend currently does not work because the _filters member is not initialized in the constructor of can.interfaces.usb2can.Usb2canBus. Call the parent class constructor to pull in the missing object attributes.
The usb2can interface currently only supports 32-bit Python on Windows, because there is no 64-bit CANAL library available yet. Mention this in the documentation section.
Codecov Report
@@ Coverage Diff @@
## develop #501 +/- ##
===========================================
- Coverage 63.87% 63.81% -0.07%
===========================================
Files 63 63
Lines 5625 5626 +1
===========================================
- Hits 3593 3590 -3
- Misses 2032 2036 +4 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #501 +/- ##
===========================================
- Coverage 63.87% 63.81% -0.07%
===========================================
Files 63 63
Lines 5625 5626 +1
===========================================
- Hits 3593 3590 -3
- Misses 2032 2036 +4 |
felixdivo
approved these changes
Feb 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing parent class initialization to fix #465.
Tested under a 32-bit Python3 environment in Windows 7.