Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CEL Python bindings to use cel-interpreter 0.10.0, bringing significant improvements to mixed-type arithmetic, error handling, and overall robustness. The update includes automatic type coercion for better int/float compatibility, enhanced error handling with proper Python exceptions, and comprehensive test coverage improvements.
Key changes:
- Updated cel-interpreter from 0.9.0 to 0.10.0 with intelligent type coercion for mixed arithmetic
- Enhanced error handling with panic protection and proper Python exception mapping
- Comprehensive test suite expansion with 10+ new test modules covering edge cases and functionality
Reviewed Changes
Copilot reviewed 27 out of 60 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Core Rust implementation with PyO3 0.25.0 migration, type coercion, and error handling |
| src/context.rs | Updated context management with new PyO3 APIs and enhanced documentation |
| tests/test_*.py | Comprehensive test suite with 10 new test modules covering types, datetime, CLI, etc. |
| python/cel/cli.py | Full-featured CLI with Rich formatting, REPL, and syntax highlighting |
| pyproject.toml | Build system updates with new dependencies and tooling configuration |
| Cargo.toml | Dependency updates to cel-interpreter 0.10.0 and PyO3 0.25.0 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.