Fix downloads-path tests timing out in headful mode#138
Open
Conversation
The acceptDownloads parameter was sent as a raw boolean over the
Playwright protocol, but the server expects string values ("accept" or
"deny"). When the server received a boolean, it did not properly
configure download behavior, causing headful browsers to show save
dialogs that blocked test execution.
Convert acceptDownloads from bool to the protocol string format in both
BrowserChannel and BrowserTypeChannel, matching the upstream TypeScript
client's toAcceptDownloadsProtocol conversion. Remove the
downloads-path.spec.ts expected-failure entry for headful mode.
Closes #107
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acceptDownloadsprotocol encoding: convert boolean to string ("accept"/"deny") to match the Playwright protocol specification, which expects string values rather than raw booleans[downloads-path.spec.ts] *expected-failure entry for headful mode from TestExpectationsTest plan
downloads-path.spec.tstests pass in headful mode (HEADLESS=false)downloads-path.spec.tstests still pass in headless modeCloses #107
🤖 Generated with Claude Code