Removing dependency on mono on linux. #1036
Conversation
|
Humm, checked the test in question and it doesn't seem like the submitted code changed anything there. Has it been flaky in the past? I also tried it on my machine, seems to be good. |
|
Resolves #1035. |
|
I think we have a real fail on PuppeteerSharp.Tests.PuppeteerTests.FixturesTests.ShouldDumpBrowserProcessStderr on .net 4.7.1 on windows. That failed every time I ran the build |
|
I'll take a look. |
|
Tests mostly seem to be good. They do timeout on the .net471 run, have this been seen before? |
|
@scabana Yeah, Our builds are quite inconsistent in AppVeyor lately. That's why I try to rebuild a few times until I confirm that we might have introduced a bug. |
|
Alright! Then, I believe I have fixed the bug (there really was a problem). Handing the next step to you for validation then. |
kblok
left a comment
kblok
left a comment
There was a problem hiding this comment.
Good Job!
Thank you for your contribution :)
Hey, my pleasure! Nice to see an active project! Got an idea of when you're planning next release? |
|
Puppeteer released 1.14 today so we'll be working on that during April. |
I think I can live with it. But that task would be far behind when it gets released. If it's not too much work to push a version with those changes, I would greatly appreciate. |
|
Thank you for your contribution @scabana. I hope this is the first of many :) |
|
Can we review de demo project @scabana ? https://ci.appveyor.com/project/kblok/puppeteer-sharp-0c8w9/builds/23475340/job/vfpp4tm2d222nk7r |
|
Good morning, sure can do... |
2 participants
Removes dlls imports to mono dependencies and replaces it an implementation provided by the mono team that does the same thing.