Browser.waitForTarget

[bdurrani]

closes #739

[kblok]

@bdurrani though it doesn't affect the final result. Try to start every new feature branching from master, so we don't get 17 commits when we should've got only one.

Take a look at the CodeFactor error.

[bdurrani]

@bdurrani though it doesn't affect the final result. Try to start every new feature branching from master, so we don't get 17 commits when we should've got only one.

Take a look at the CodeFactor error.

I'm not sure what I'm doing wrong here. I merge any changes in your repo into mine on the master branch before creating a new branch or pushing any new changes. I've been following these steps here.

[kblok]

@bdurrani you can do something like this

git checkout upstream/master -b some-feature --no-track

[bdurrani]

@bdurrani you can do something like this

git checkout upstream/master -b some-feature --no-track

I'll give this a shot! I'm aiming to wrap up this PR by the end of the day. Thanks

[kblok]

Almost there. Great job!

[bdurrani]

strange.. That failing test was passing previously and the only change i made was remove that one redundant line in the test.
All the tests seem to pass locally

[kblok]

@bdurrani it was a hiccup :)