Provides support to minimize to system tray#21
Merged
jonian merged 2 commits intohardpixel:masterfrom Dec 3, 2020
Merged
Conversation
Member
|
Hi @andrecbarros, thank you for your contribution! This is a very nice feature to add. The only issue I see is that ctrl + ↑ and ctrl + ↓ are used by devdocs web-app to scroll to top/bottom of the docs. Since devdocs-desktop does not have it's own settings window (yet), can we set ctrl + meta + up/down as shortucts? |
Contributor
Author
|
Yes, will change it. |
Modify iconify shortcut to be Ctrl+Alt+PgUp or Ctrl+Alt+PgDn
Contributor
Author
|
Added your project to a package on opensuse:DevDocs API documentation browser
|
|
|
| | |
|
|
|
| |
DevDocs API documentation browser
DevDocs Python/GTK3 application for browsing multiple API documentations
|
|
|
Thanks for sharing your nice project.
Cheers,André
On Friday, November 27, 2020, 8:25:01 AM GMT-3, Jonian Guveli <notifications@github.com> wrote:
Hi @andrecbarros, thank you for your contribution! This is a very nice feature to add.
The only issue I see is that ctrl + ↑ and ctrl + ↓ are used by devdocs web-app to scroll to top/bottom of the docs.
Since devdocs-desktop does not have it's own settings window (yet), can we set ctrl + meta + up/down as shortucts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
@andrecbarros is this ready to merge? I tried your branch and the shortcuts are not working. Maybe I did something wrong. |
Contributor
Author
|
The only difference to the one I'm using is that I select python3 explicitly on header.
I'm using it on openSUSE Tumbleweed, will check how things work on Ubuntu 18.0.4 and will post the result in a couple of minutes.
Hold on.
On Tuesday, December 1, 2020, 6:05:06 PM GMT-3, Jonian Guveli <notifications@github.com> wrote:
@andrecbarros is this ready to merge? I tried your branch and the shortcuts are not working. Maybe I did something wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Contributor
Author
|
One more thing, Cntrl+Alt+(Up|Dn) changes virtual desktop on Ubuntu (perhaps, it does it too on Gnome) and, as these keys share locations with PgUp/PgDn on current notebooks, it would be wise to avoid using them as shortcuts. Anyway, will change the code to deal with user selection options.
Regards,André
On Tuesday, December 1, 2020, 6:05:06 PM GMT-3, Jonian Guveli <notifications@github.com> wrote:
@andrecbarros is this ready to merge? I tried your branch and the shortcuts are not working. Maybe I did something wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
I misunderstood the shortcuts, it works fine! I think this should be merged as is and we can add settings for shortcuts in another PR, after I create a settings screen. What do you think? |
Contributor
Author
|
Your app is already great, perhaps, a little patience should be exercised to produce a release everybody may enjoy and no one would put forward regrets.
If it were for my vote, I would advise waiting until the "user selected shortcuts" and optional "minimize to tray" are ready to issue a new release.
Nothing against merging the changes to code repository, though.
Regards,André
On Wednesday, December 2, 2020, 10:42:29 AM GMT-3, Jonian Guveli <notifications@github.com> wrote:
I misunderstood the shortcuts, it works fine! I think this should be merged as is and we can add settings for shortcuts in another PR, after I create a settings screen.
What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
I have to revert this since it relies on the deprecated
Related docs here. |
Contributor
Author
|
Hi,
Will take a look next week, after I deliver a system I´m finishing right now (hopefully, today).
On Sunday, December 6, 2020, 8:37:45 AM GMT-3, Jonian Guveli <notifications@github.com> wrote:
I have to revert this since it relies on the deprecated Gtk.StatusIcon. I really liked this feature and I think it should be implemented using the recommendation from the GTK docs.
Gtk.StatusIcon has been deprecated in 3.14. You should consider using notifications or more modern platform-specific APIs instead. GLib provides the Gio.Notification API which works well with Gtk.Application on multiple platforms and environments, and should be the preferred mechanism to notify the users of transient status updates. See this HowDoI for code examples.
Related docs here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devdocs-desktop now can be iconified/deiconified to system tray.