Skip to content

♻ refactor(mq-lang): add opening delimiter location to unclosed bracket errors#1514

Merged
harehare merged 2 commits intomainfrom
refactor/unclosed-delimiter-diagnostics
Mar 30, 2026
Merged

♻ refactor(mq-lang): add opening delimiter location to unclosed bracket errors#1514
harehare merged 2 commits intomainfrom
refactor/unclosed-delimiter-diagnostics

Conversation

@harehare
Copy link
Copy Markdown
Owner

Enhance ExpectedClosingParen/Brace/Bracket errors to carry the opening token, enabling diagnostics to show both where the closing delimiter was expected and where the matching opening delimiter appears.

…et errors

Enhance ExpectedClosingParen/Brace/Bracket errors to carry the opening
token, enabling diagnostics to show both where the closing delimiter was
expected and where the matching opening delimiter appears.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 29, 2026

Merging this PR will improve performance by 16.05%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 28 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
eval_variable_assignment_chain 955.8 µs 823.6 µs +16.05%

Comparing refactor/unclosed-delimiter-diagnostics (619615f) with main (5d6a6c7)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (1d300e6) during the generation of this report, so 5d6a6c7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@harehare harehare merged commit 62256a0 into main Mar 30, 2026
6 checks passed
@harehare harehare deleted the refactor/unclosed-delimiter-diagnostics branch March 30, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant