🐛 fix(eval): prevent stack overflow when user function shadows a builtin#1734
Merged
Conversation
When a user-defined function has the same name as a native builtin, calls to that name within the function body now resolve to the native builtin instead of recursing back into the user-defined function. This is done by binding NativeFunction(ident) into the body's new_env whenever the called function name matches a known builtin. As a result, the outer scope continues to use the user-defined version (override semantics), while the body can safely call the same-named builtin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user-defined function has the same name as a native builtin, calls to that name within the function body now resolve to the native builtin instead of recursing back into the user-defined function.
This is done by binding NativeFunction(ident) into the body's new_env whenever the called function name matches a known builtin. As a result, the outer scope continues to use the user-defined version (override semantics), while the body can safely call the same-named builtin.