-
Notifications
You must be signed in to change notification settings - Fork 36
Added enable flag to allow for toggling sticky behavior #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh, nice feature ;) From the looks of it the changes seem good, though I'm not sure if they work in every situation. I'm not sure if it also works if you toggle the |
|
And let's not forget the documentation as well. But I can do that for you if you like. |
|
Wanted to see if you like the impementation first :) Added tests and documentation. Sorry for the commit confusion, I switched between work and personal. |
|
Good call ;) Thanks for the additions, it's starting to take shape. The unit tests probably cover all your code, but not on the services necessarily. The "hlSticky" directive I think is covered very nicely, but the following service is not yet covered: And btw, now that I think about it. What happens if you have a stack of 3 and the second one is turned off? |
…, addede tests for enabled option
|
Thanks for pointing that out, I missed that. Should now be fixed and I also added some more tests. |
|
Looks good now from what I can see from the code! Hopefully within a few hours I can review it in more detail. Otherwise it will be tonight. But once again, thanks for the feature ;) |
|
All right, everything is done! Great feature mate ;) It has been release in version |
We need to toggle sticky behavior on/off based on different conditions. Would you be willing to integrate this change and if so could you check if the PR needs any more adjustments?