docs: added doc support for file-addition-trigger #1240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for harness-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
harish-viswa
force-pushed
the
docs/file-addition-trigger
branch
from
e1ee610 to
3386c25
Compare
harish-viswa
force-pushed
the
docs/file-addition-trigger
branch
from
3386c25 to
70e234d
Compare
knagurski
reviewed
Mar 14, 2025
Collaborator
knagurski
left a comment
knagurski
left a comment
There was a problem hiding this comment.
Looks like the props don't quite match the component itself
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
knagurski
reviewed
Mar 14, 2025
apps/portal/src/content/docs/components/file-additions-trigger.mdx
Outdated
Show resolved
Hide resolved
….mdx Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
….mdx Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
….mdx Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
….mdx Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
….mdx Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
….mdx Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
….mdx Co-authored-by: Kevin Nagurski <Kevin.nagurski@harness.io>
knagurski
reviewed
Apr 2, 2025
Comment on lines
+41
to
+43
| useTranslationStore={useTranslationStoreHook} | ||
| pathNewFile="/new-file" | ||
| pathUploadFiles="/upload-files" |
Collaborator
There was a problem hiding this comment.
Can we add a quick comment for each of the props to briefly explain them?
Suggested change
| useTranslationStore={useTranslationStoreHook} | |
| pathNewFile="/new-file" | |
| pathUploadFiles="/upload-files" | |
| useTranslationStore={useTranslationStoreHook} // something interesting | |
| pathNewFile="/new-file" // something else | |
| pathUploadFiles="/upload-files" // and some more |
knagurski
reviewed
Apr 2, 2025
Collaborator
knagurski
left a comment
knagurski
left a comment
There was a problem hiding this comment.
Just a little inline explanation and we're good to go 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1239