(FFM-5400) Improve redis startup process #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Bug FFM-5400 · [Proxy] Github issue #110 redis cluster MOVED error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When starting the proxy connected to redis we don't have a strict healthcheck on startup. This means we might fail to connect properly and then log errors later when we can't write to the cache instead of failing early.
This isn't super helpful because it's not overly clear that we failed to connect to redis in the first place, it looks more to a user like the issue is in our caching code itself.
Solution
Have a strict redis healthcheck on startup.
Specify in docs that we don't support clustered redis instances.
Other info
These improvements have come from the issue raised here - #110 where it wasn't immediately obvious what the underlying issue was on startup and led to cache errors later.