Avoid creating separate enum for stopped motors#30
Merged
Conversation
bruno-f-cruz
approved these changes
Apr 2, 2024
| <PackageOutputPath>..\bin\$(Configuration)</PackageOutputPath> | ||
| <TargetFrameworks>net462;netstandard2.0</TargetFrameworks> | ||
| <VersionPrefix>0.3.0-build2024032601</VersionPrefix> | ||
| <VersionPrefix>0.3.0-build240401</VersionPrefix> |
Member
There was a problem hiding this comment.
We really should agree on this at some point...
Contributor
Author
There was a problem hiding this comment.
@bruno-f-cruz yup, my convention right now is YYMMBB which I realize makes for a good balance between conciseness and rate of releases. The BB stands for "build number" in the month. So 240401 means the first build of April. I just realized over time that the exact day means very little to me here, you always have the commit for really fine precision if you need to, and having just a sense of the month is usually enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current schema uses a separate enum
StoppedMotorsto indicate jointly the state of stopped motors and a signal of which motor caused the change in the event.This PR avoids the redundancy by specifying a payload spec in the schema for the
MotorStoppedregister.