Omit mask name suffix from firmware group masks#115
Merged
glopesdev merged 1 commit intoharp-tech:mainfrom Mar 22, 2026
Merged
Conversation
Firmware mask names cannot clash with register names so a suffix is currently required. If the common Mask suffix is used, it will be dropped from firmware definitions since enum classes are not available in C and therefore no name clash exists. Refactored firmware naming convention functions into common helper class.
glopesdev
force-pushed
the
firmware-mask-suffix
branch
from
38925af to
68df6cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firmware mask names cannot clash with register names so a suffix is currently required.
If the common
Masksuffix is used, the generators will drop the suffix word from firmware definition names. Since enum classes are not available in C we already have to use a differentiating prefix (GM_), so there is no name clash and no need for the redundant suffix.Firmware naming convention functions were also refactored into the common helper class to ease future maintenance revisions.
Closes #113