Skip to content

Conversation

@glopesdev
Copy link
Collaborator

@glopesdev glopesdev commented Nov 18, 2025

As described in #71, error handling is a growing concern for consistent implementation of Harp device interfaces. The new section introduced in this PR aims to provide clearer guidelines on how various kinds of errors should be handled and reported.

Closes #71

@glopesdev glopesdev requested a review from a team November 18, 2025 10:00
@glopesdev glopesdev added the documentation Improvements or additions to documentation label Nov 18, 2025
@glopesdev glopesdev force-pushed the dev/error-bit-clarifications branch 7 times, most recently from 91085f4 to 77a5e9c Compare November 18, 2025 12:07
@glopesdev glopesdev force-pushed the dev/error-bit-clarifications branch from 77a5e9c to a87d3f6 Compare November 18, 2025 12:11
@glopesdev
Copy link
Collaborator Author

@bruno-f-cruz We could probably also resolve #55 in this PR. Leaving it here for discussion.

@bruno-f-cruz
Copy link
Member

bruno-f-cruz commented Nov 18, 2025

@bruno-f-cruz We could probably also resolve #55 in this PR. Leaving it here for discussion.

If the goal of "mute replies" is to stop any feedback from a command from the device, then I still think that suppressing the error response falls within this category.
My interpretation is that the error message is that it is still trying to fulfil the 1 request : 1 response contract. By enabling disabling this flag one would be instructing the device to explicitly NOT follow the contract.

@glopesdev
Copy link
Collaborator Author

glopesdev commented Nov 18, 2025

By disabling this flag one would be instructing the device to explicitly NOT follow the contract.

Just to clarify, I'm assuming you mean here to set the flag. I'm fine with any interpretation, but I would be interested in hearing from @filcarv and @Poofjunior what exactly is implemented in core.atxmega and core.pico and whether both match this (and each other).

If not, we need to decide what to change to make things consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error bit should be used only to validate message payload

2 participants