-
Notifications
You must be signed in to change notification settings - Fork 6
Use consistent notation for array registers #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Array registers should be clearly indicated in the table and hyperlinks. The length of all array registers is now clearly indicated in the register specification.
fb42da7 to
88de5b1
Compare
bruno-f-cruz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with merging as is.
However I still wonder if we should not explicitly state the length of registers more prominently. For instance, is it clear why the data type (eg U8) is in the title but not the length or the register? All registers have both attributes (most length =1, but still...)
@bruno-f-cruz the problem is we really have no more space available in the table without breaking formatting. There are tons of details per register, most of them are not even visible in the table at all, and they are in my opinion even more important than knowing the lengths of these specific registers, so it's a tradeoff. I am happy to take suggestions though. |
How about we do the following in the text: R_FOO – Short Foo descriptionAddress: 000 |
fc936da to
ad7be16
Compare
|
@bruno-f-cruz fair enough, I added the length to all register specifications. |
Array registers should be clearly indicated in the table and hyperlinks. The length of all array registers is now clearly indicated in the register specification.
Fixes #177