Skip to content

fix: check window valid when refocusing after closing popup#527

Merged
harrisoncramer merged 1 commit intoharrisoncramer:developfrom
jakubbortlik:fix/invalid-window
Mar 18, 2026
Merged

fix: check window valid when refocusing after closing popup#527
harrisoncramer merged 1 commit intoharrisoncramer:developfrom
jakubbortlik:fix/invalid-window

Conversation

@jakubbortlik
Copy link
Collaborator

This PR fixes the error that is thrown if the last active window from which a popup was opened is no longer valid when closing the popup.

Reproduction steps:

  • Start a review: glS
  • Focus the discussion tree if not already focused
  • type gls to show the summary
  • type gld to hide the discussion tree
  • type gls to close the summary

@harrisoncramer harrisoncramer merged commit c82c667 into harrisoncramer:develop Mar 18, 2026
4 checks passed
@jakubbortlik jakubbortlik deleted the fix/invalid-window branch March 18, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants