fix: encode empty merge_requests body as JSON object instead of array#554
Merged
jakubbortlik merged 1 commit intoharrisoncramer:developfrom Apr 29, 2026
Merged
Conversation
When choose_merge_request() is called without arguments, the body
function returns an empty Lua table {} which vim.json.encode serializes
as a JSON array []. The Go server expects a JSON object and fails with:
'cannot unmarshal array into Go value of type ListProjectMergeRequestsOptions'
Using vim.empty_dict() ensures the empty table is encoded as {} instead.
3 tasks
Collaborator
|
Thanks for reporting and fixing this! |
Contributor
Author
|
No problem, happy to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When choose_merge_request() is called without arguments, the body function returns an empty Lua table {} which vim.json.encode serializes as a JSON array []. The Go server expects a JSON object and fails with: 'cannot unmarshal array into Go value of type ListProjectMergeRequestsOptions'
Using vim.empty_dict() ensures the empty table is encoded as {} instead.