Refactor Onboarding name validation to use state-driven UI#127
Merged
harrydbarnes merged 1 commit into2.0from Jan 26, 2026
Merged
Conversation
Replaces the imperative Toast-based validation in OnboardingScreen with a reactive approach. - Added `nameError` state to `OnboardingViewModel`. - Updated `WelcomeStep` to display validation errors using `OutlinedTextField`'s `isError` and `supportingText`. - Extracted error message to `strings.xml`. - Added `OnboardingViewModelTest`.
harrydbarnes
deleted the
refactor-onboarding-validation-3301151275267496739
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the imperative Toast-based validation in OnboardingScreen with a reactive approach.
nameErrorstate toOnboardingViewModel.WelcomeStepto display validation errors usingOutlinedTextField'sisErrorandsupportingText.strings.xml.OnboardingViewModelTest.