Skip to content

Feat/add vocab#57

Merged
harumiWeb merged 12 commits into
mainfrom
feat/add-vocab
Apr 20, 2026
Merged

Feat/add vocab#57
harumiWeb merged 12 commits into
mainfrom
feat/add-vocab

Conversation

@harumiWeb
Copy link
Copy Markdown
Owner

@harumiWeb harumiWeb commented Apr 20, 2026


Open in Devin Review

Summary by CodeRabbit

  • Documentation
    • Expanded embedded vocabulary to approximately 10,000 words (from ~8,000)
    • Released version 0.8.0
    • Updated changelog and documentation to reflect the vocabulary expansion

harumiWeb and others added 9 commits April 19, 2026 13:53
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix mistranslated or misclassified bundled-core entries in the new vocabulary additions and keep the reviewed batch changes together.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Correct the missed peacefulness abstract-noun classification and sync the batch notes with the applied audit result.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix oversimplification gloss and ruminate distractor group.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Refine locket, gangly, and lanky after code review.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adjust reviewed meanings and distractor groups for the latest additions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@harumiWeb harumiWeb requested a review from Copilot April 20, 2026 11:05
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@harumiWeb has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 57 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 57 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a13c24f9-3c13-470d-85ea-0a99639f939e

📥 Commits

Reviewing files that changed from the base of the PR and between 23cd97e and 0a32462.

📒 Files selected for processing (9)
  • CHANGELOG.md
  • README.en.md
  • README.md
  • docs/adr/0002-bundled-core-dictionary-lifecycle.md
  • docs/specs/bundled-core-vocabulary-workflow.md
  • docs/specs/session-modes.md
  • internal/dict/embed.go
  • tasks/feature_spec.md
  • tasks/todo.md
📝 Walkthrough

Walkthrough

This PR updates documentation and task planning files to reflect a vocabulary expansion from approximately 8,000 to 10,000 words. Changes include a new release version entry in the changelog, updated vocabulary counts in README files, and new task specifications and checklists for vocabulary batch processing (seed ranges 31000-37000).

Changes

Cohort / File(s) Summary
Release Notes and Documentation
CHANGELOG.md, README.en.md, README.md
Added new version 0.8.0 release entry with vocabulary expansion details (10,165 core words). Updated embedded vocabulary size documentation from ~8000 to ~10000 words across English and Japanese README files.
Task Planning and Specifications
tasks/feature_spec.md, tasks/todo.md
Added detailed batch processing specifications and checklist items for vocabulary seed batches (31000-37000 range), including review procedures, spot audits, validation commands, and acceptance criteria. Documented parallel review workflows and merge/sync procedures for core vocabulary updates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • add changelog #2: Updates CHANGELOG.md with version 0.8.0 release information, directly modifying the same file and continuing the vocabulary release documentation introduced in the retrieved PR.
  • docs: replace design doc with ADRs #5: Related through shared vocabulary expansion workflows and core dictionary lifecycle management; both PRs involve seed batch processing, core vocabulary validation, and assets/words_core.jsonl updates.

Poem

🐰✨ Ten thousand words, now bundled tight,
Vocabulary grew through night,
Seeds were planted, batches reviewed,
Tasks are planned, the specs renewed,
Our lexicon now shines so bright! 📚

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Feat/add vocab' is vague and generic, using non-descriptive terms that don't convey meaningful information about the actual changes. Replace with a more specific title that describes the actual change, such as 'Update embedded vocabulary from 8000 to 10000 words' or 'Add 36000-37000 vocabulary seed batch'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-vocab

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 20, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

🐛 1 issue in files not directly in the diff

🐛 CoreWordsVersion not bumped — existing users will not receive ~2127 new vocabulary words (internal/dict/embed.go:9)

The PR adds 2127 new entries to assets/words_core.jsonl (from 8038 to 10165 lines), but internal/dict/embed.go:9 still has CoreWordsVersion = "2026-04-11-leipzig-wnjpn-core-8k-v16". The SeedWords function at internal/store/migrate.go:82-84 short-circuits with return nil when currentVersion == version, so existing users whose database already stores this version string will never receive the new words. Only fresh installs will get the full 10165-word dictionary. The doctor diagnostic (internal/store/doctor.go:199) will also fail to flag the mismatch. This completely defeats the purpose of the PR for any upgrading user.

View 2 additional findings in Devin Review.

Open in Devin Review

coderabbitai[bot]

This comment was marked as resolved.

This comment was marked as resolved.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

This comment was marked as resolved.

harumiWeb and others added 2 commits April 20, 2026 21:48
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@harumiWeb harumiWeb merged commit da34ff0 into main Apr 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants