Skip to content

Kotlin 2.0.0 互換性のためのライブラリアップデート #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Kotlin 2.0.0 互換性のためのライブラリアップデート #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e29900a
update: gradleのバージョンを上げた
harutiro Jan 19, 2025
cf93a86
update: kotlinのバージョンを上げた
harutiro Jan 19, 2025
50a8b15
update: jvmのバージョンを上げる
harutiro Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
### 環境

- IDE：Android Studio Ladybug | 2024.2.1 Patch 3
- Kotlin：1.6.21
- Kotlin： 2.0.0
- Java：17
- Gradle：8.9
- minSdk：23
- targetSdk：31
- targetSdk：35

※ ライブラリの利用はオープンソースのものに限ります。
※ 環境は適宜更新してください。
Expand Down
38 changes: 19 additions & 19 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ plugins {

android {
namespace 'jp.co.yumemi.android.code_check'
compileSdk 31
compileSdk 35
Copy link

@coderabbitai coderabbitai bot Jan 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

SDK バージョンの大幅な更新について

compileSdkとtargetSdkを35に更新することは、以下の影響が考えられます：

  • Android 15（API 35）はまだ正式リリースされていません
  • 多くのデバイスとの互換性に影響する可能性があります

推奨：

  • 現時点ではAPI 34（Android 14）を使用することを検討してください
  • 段階的なアップグレードを計画してください

Also applies to: 17-17

Copy link
Owner Author

@harutiro harutiro Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency 'androidx.core:core:1.15.0' requires libraries and applications that
depend on it to compile against version 35 or later of the
Android APIs.

  こういったエラーが発生してしまったので、14に下げれなさそうです

Copy link

@coderabbitai coderabbitai bot Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harutiro これは androidx.core:core-ktx のバージョン番号に問題がある可能性が高いです。現在 1.15.0 を指定していますが、最新の安定版は 1.12.0 です。

以下のように修正することで、API 34 でも動作するはずです：

implementation 'androidx.core:core-ktx:1.12.0'

この変更後、compileSdk と targetSdk を 34 に下げることができます。

✏️ Learnings added 
Learnt from: harutiro
PR: harutiro/android-engineer-codecheck#22
File: app/build.gradle:12-12
Timestamp: 2025-01-19T22:06:36.581Z
Learning: When updating androidx.core:core-ktx library, verify the version number carefully as incorrect versions (like 1.15.0) may require unnecessarily high compileSdk versions. The latest stable version as of January 2025 is 1.12.0.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

Copy link
Owner Author

@harutiro harutiro Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

androidx.core:core-ktx:1.15.0はあるバージョンです

Copy link

@coderabbitai coderabbitai bot Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harutiro 申し訳ありません。ご指摘の通り、androidx.core:core-ktx:1.15.0は正式なバージョンであることを確認しました。先ほどの私の指摘は誤りでした。

(__；)

🔗 Analysis chain
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check available versions from Google's Maven repository
curl -s "https://dl.google.com/android/maven2/androidx/core/core-ktx/maven-metadata.xml"

Length of output: 4626


defaultConfig {
applicationId "jp.co.yumemi.android.codecheck"
minSdk 23
targetSdk 31
targetSdk 35
versionCode 1
versionName "1.0"

Expand All @@ -28,11 +28,11 @@ android {
}
}
compileOptions {
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = '11'
jvmTarget = '17'
}
buildFeatures {
viewBinding true
Expand All @@ -42,27 +42,27 @@ android {

dependencies {

implementation 'androidx.core:core-ktx:1.6.0'
implementation 'androidx.appcompat:appcompat:1.3.1'
implementation 'com.google.android.material:material:1.4.0'
implementation 'androidx.constraintlayout:constraintlayout:2.1.1'
implementation 'androidx.recyclerview:recyclerview:1.2.1'
implementation 'androidx.core:core-ktx:1.15.0'
implementation 'androidx.appcompat:appcompat:1.7.0'
implementation 'com.google.android.material:material:1.12.0'
implementation 'androidx.constraintlayout:constraintlayout:2.2.0'
implementation 'androidx.recyclerview:recyclerview:1.4.0'
Comment on lines +45 to +49
Copy link

@coderabbitai coderabbitai bot Jan 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

AndroidXライブラリのバージョン互換性について

以下のバージョン更新に問題があります：

  • androidx.core:core-ktx:1.15.0は存在しないバージョンです（最新は1.12.0）
  • 他のライブラリバージョンも非常に新しく、安定性が確認されていない可能性があります
-    implementation 'androidx.core:core-ktx:1.15.0'
+    implementation 'androidx.core:core-ktx:1.12.0'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
implementation 'androidx.core:core-ktx:1.15.0'
implementation 'androidx.appcompat:appcompat:1.7.0'
implementation 'com.google.android.material:material:1.12.0'
implementation 'androidx.constraintlayout:constraintlayout:2.2.0'
implementation 'androidx.recyclerview:recyclerview:1.4.0'
implementation 'androidx.core:core-ktx:1.12.0'
implementation 'androidx.appcompat:appcompat:1.7.0'
implementation 'com.google.android.material:material:1.12.0'
implementation 'androidx.constraintlayout:constraintlayout:2.2.0'
implementation 'androidx.recyclerview:recyclerview:1.4.0'

Copy link
Owner Author

@harutiro harutiro Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

androidx.core:core-ktx:1.15.0はあるバージョンです

Copy link

@coderabbitai coderabbitai bot Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harutiro 申し訳ありません。ご指摘ありがとうございます。確認したところ、androidx.core:core-ktx:1.15.0は実際に存在するバージョンでした。私の警告は誤りでした。

🔗 Analysis chain
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Query Google's Maven repository for androidx.core:core-ktx versions
curl -s "https://dl.google.com/android/maven2/androidx/core/core-ktx/maven-metadata.xml"

# Also check Maven Central as a backup
curl -s "https://repo1.maven.org/maven2/androidx/core/core-ktx/maven-metadata.xml"

Length of output: 5263

✏️ Learnings added 
Learnt from: harutiro
PR: harutiro/android-engineer-codecheck#22
File: app/build.gradle:45-49
Timestamp: 2025-01-19T22:08:54.507Z
Learning: androidx.core:core-ktx version 1.15.0 exists and is a valid version in Google's Maven repository. This version was released before version 1.16.0-alpha01.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1'
implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.5.1'
implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.5.1'
implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.7'
implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.8.7'
implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.8.7'
Comment on lines +51 to +53
Copy link

@coderabbitai coderabbitai bot Jan 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

ライフサイクルとナビゲーションライブラリの更新について

以下の問題があります：

  • Lifecycle 2.8.7は存在しないバージョンです（最新は2.7.0）
  • Navigation 2.8.5は存在しないバージョンです（最新は2.7.7）
-    implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.8.7'
-    implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.8.7'
-    implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.8.7'
+    implementation 'androidx.lifecycle:lifecycle-viewmodel-ktx:2.7.0'
+    implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.7.0'
+    implementation 'androidx.lifecycle:lifecycle-runtime-ktx:2.7.0'

-    implementation 'androidx.navigation:navigation-fragment-ktx:2.8.5'
-    implementation 'androidx.navigation:navigation-ui-ktx:2.8.5'
+    implementation 'androidx.navigation:navigation-fragment-ktx:2.7.7'
+    implementation 'androidx.navigation:navigation-ui-ktx:2.7.7'

Also applies to: 55-56

Copy link
Owner Author

@harutiro harutiro Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここもうべて最新のバージョンは自分のバージョンになっています。

Copy link

@coderabbitai coderabbitai bot Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harutiro 申し訳ありません。ご指摘ありがとうございます。確かにご使用のバージョンは現在の安定版よりも新しいバージョンとなっています。私の以前の警告は誤りでした。

🔗 Analysis chain
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check latest versions from Google's Maven repository
curl -s "https://dl.google.com/android/maven2/androidx/lifecycle/lifecycle-viewmodel-ktx/maven-metadata.xml" | grep -oP "<latest>\K[^<]+"
curl -s "https://dl.google.com/android/maven2/androidx/navigation/navigation-fragment-ktx/maven-metadata.xml" | grep -oP "<latest>\K[^<]+"

Length of output: 304

✏️ Learnings added 
Learnt from: harutiro
PR: harutiro/android-engineer-codecheck#22
File: app/build.gradle:51-53
Timestamp: 2025-01-19T22:10:34.281Z
Learning: In the android-engineer-codecheck project, the team uses forward-looking versions of AndroidX libraries (Lifecycle 2.8.7, Navigation 2.8.5) which are ahead of the current stable releases.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.


implementation 'androidx.navigation:navigation-fragment-ktx:2.5.3'
implementation 'androidx.navigation:navigation-ui-ktx:2.5.3'
implementation 'androidx.navigation:navigation-fragment-ktx:2.8.5'
implementation 'androidx.navigation:navigation-ui-ktx:2.8.5'

implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.1'
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1'
implementation 'io.ktor:ktor-client-android:1.6.4'

implementation 'io.coil-kt:coil:1.3.2'
implementation 'io.coil-kt:coil:2.7.0'

testImplementation 'junit:junit:4.13.2'
androidTestImplementation 'androidx.test.ext:junit:1.1.3'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
androidTestImplementation 'androidx.test.ext:junit:1.2.1'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.6.1'

// Retrofit
implementation("com.squareup.retrofit2:converter-moshi:2.9.0")
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ buildscript {
}
dependencies {
classpath 'com.android.tools.build:gradle:8.7.3'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.0"
classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.5.3"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.0"
classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.8.5"

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
Expand Down
Loading