Merged
Conversation
gracewhitney
reviewed
Aug 3, 2020
gracewhitney
left a comment
gracewhitney
left a comment
There was a problem hiding this comment.
Mostly looks good, I had a few comments about code similarity between the horizontal and vertical cases as well as a handful of other very minor issues/questions.
gabeabrams
requested changes
Aug 4, 2020
Contributor
gabeabrams
left a comment
gabeabrams
left a comment
There was a problem hiding this comment.
This is crazy brilliant work. I agree with most of Grace's comments, but in general, this is very complicated work. Great job!
gabeabrams
requested changes
Aug 4, 2020
| // if tickXOffset defined, set legend offset to be | ||
| // tickXOffset + tickSize + tickPadding + 15 extra px, | ||
| // Default to 60 otherwise | ||
| legendOffset: (tickXOffset ? tickXOffset + 5 + 5 + 15 : 60), |
Contributor
There was a problem hiding this comment.
Plan: fix in parallel with widget creation.
Discuss later: where will the constants go? How will we structure/modularize constants and math?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented shared barchart component and refactored the attempts widget to use it.