Skip to content

Add description for UpgradeLog enhancement#349

Merged
starbops merged 1 commit intoharvester:mainfrom
starbops:doc-4056
Jul 26, 2023
Merged

Add description for UpgradeLog enhancement#349
starbops merged 1 commit intoharvester:mainfrom
starbops:doc-4056

Conversation

@starbops
Copy link
Member

@starbops starbops commented Jul 12, 2023

Related issue: harvester/harvester#4056

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 68f6695
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64c08d177f975d00089522e8
😎 Deploy Preview https://deploy-preview-349--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@starbops starbops marked this pull request as ready for review July 12, 2023 04:53
@LucasSaintarbor LucasSaintarbor added this to the v1.2.0 milestone Jul 17, 2023
@starbops starbops requested review from bk201 and vickyhella July 20, 2023 01:31
@starbops
Copy link
Member Author

I will add a workaround for users who cannot download the UpgradeLog archive due to insufficient disk storage (the log-archive volume) in harvester/harvester#4222. Convert this back to a draft.

@starbops starbops marked this pull request as draft July 20, 2023 03:22
Copy link
Contributor

@vickyhella vickyhella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits ^^

@starbops
Copy link
Member Author

Hi @vickyhella, I've updated the sentences. Thanks for the suggestions and PTAL.

Copy link
Contributor

@vickyhella vickyhella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small typo. The rest are good to me.

@starbops
Copy link
Member Author

Hi @vickyhella, I've corrected the typo. And there's more update about the operations to expand the volume in the last commit. PTAL, thanks!

Copy link
Contributor

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Including the basic usage of UpgradeLog and a workaround when the volume
running out of room.

Signed-off-by: Zespre Chang <zespre.chang@suse.com>
@starbops starbops merged commit d726dca into harvester:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants