Skip to content

Update harvester-csi-driver prerequisites#998

Merged
Vicente-Cheng merged 1 commit intoharvester:mainfrom
brandboat:update-csi-driver-doc
Apr 10, 2026
Merged

Update harvester-csi-driver prerequisites#998
Vicente-Cheng merged 1 commit intoharvester:mainfrom
brandboat:update-csi-driver-doc

Conversation

@brandboat
Copy link
Copy Markdown
Member

update the harvester-csi-driver prerequisites

Signed-off-by: Cooper Tseng <cooper.tseng@suse.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Harvester CSI Driver documentation to clarify an additional prerequisite introduced with CSI driver v0.1.25 when installing without the Harvester cloud provider.

Changes:

  • Added a prerequisite note warning that volume snapshot components must be installed for v0.1.25+ installs without the Harvester cloud provider to avoid chart installation failures.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- The Kubernetes cluster is built on top of Harvester virtual machines.
- The Harvester virtual machines that run as guest Kubernetes nodes are in the same namespace.
- Starting with v0.1.25, if you install the CSI driver without enabling the Harvester cloud provider, ensure that [Volume Snapshots](./csi-driver.md#volume-snapshots) are properly installed; otherwise, the chart installation will fail.
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prerequisite bullet says "ensure that Volume Snapshots are properly installed", but volume snapshots aren’t something you install directly; what’s required is the CSI snapshot controller + CRDs/manifests (as described later in the Volume Snapshots prerequisites). Consider rephrasing this to explicitly reference installing the snapshot controller/CRDs so readers know what to do and what component causes the chart install to fail.

Suggested change
- Starting with v0.1.25, if you install the CSI driver without enabling the Harvester cloud provider, ensure that [Volume Snapshots](./csi-driver.md#volume-snapshots) are properly installed; otherwise, the chart installation will fail.
- Starting with v0.1.25, if you install the CSI driver without enabling the Harvester cloud provider, ensure that the CSI snapshot controller and VolumeSnapshot CRDs/manifests described in [Volume Snapshots](./csi-driver.md#volume-snapshots) are installed; otherwise, the chart installation will fail.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

Name Link
🔨 Latest commit b584a49
😎 Deploy Preview https://69c6256460b9713ece95acae--harvester-preview.netlify.app

@Vicente-Cheng Vicente-Cheng merged commit f1087b5 into harvester:main Apr 10, 2026
9 checks passed
@Vicente-Cheng
Copy link
Copy Markdown
Contributor

Sorry I missed that.
@brandboat, do we need to add this to the v1.7 document since we support snapshot with Harvester v1.7

@brandboat
Copy link
Copy Markdown
Member Author

You're right, let me file another pr

@brandboat
Copy link
Copy Markdown
Member Author

@Vicente-Cheng, here it is #1008 (comment)

@brandboat brandboat deleted the update-csi-driver-doc branch April 10, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants