[e2e] update test cases for volume storage class naming changes#2524
Merged
khushboo-rancher merged 2 commits intoharvester:mainfrom Mar 19, 2026
Merged
[e2e] update test cases for volume storage class naming changes#2524khushboo-rancher merged 2 commits intoharvester:mainfrom
khushboo-rancher merged 2 commits intoharvester:mainfrom
Conversation
Signed-off-by: Lanfon Fan <lanfon.fan@suse.com>
ddaf660 to
4c4a938
Compare
Member
Author
|
the keyword to filter test cases (which changed in this PR): |
Signed-off-by: Lanfon Fan <lanfon.fan@suse.com>
khushboo-rancher
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #1189 (from harvester/harvester#5165)
What this PR does / why we need it:
v1.8.0introduce the new storage class naming for volume (created with image), it will affect our existing test cases.Special notes for your reviewer:
Test case updated:
Implementation details
VolManager180to expand the create function forimage_uidVolumeSpec180to handle the new argumentimage_uidVolumeSpec.for_imageas the handy method to create volume with image.Demonstration
Caveats
image_uidbut do nothing in old implementationfor_imagewill handle the legacy/new storage class name viaimage_info.status.storageClassName, but the value might be empty if the image was not succeed downloaded. (or other case that the image is not usable)image_uidto VolumeSpec. (the old way)