Add test cases of cpu mem hotplug#2663
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional Harvester E2E coverage for CPU/Memory hotplug behavior during VM creation, including toggling hotplug on/off in the spec, setting custom maximums, and validating server-side rejection for invalid maximum CPU/memory values.
Changes:
- Add a test that enables CPU/mem hotplug and then disables it before creating the VM, verifying the resulting VM spec reflects “disabled”.
- Add a test that creates a VM with CPU/mem hotplug enabled using custom max CPU/mem limits.
- Add negative test coverage for invalid
max_cpu/max_memvalues and assert the API rejects the VM creation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: asc5543 <asc5543@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #1695
What this PR does / why we need it:
Add test cases of cpu mem hotplug to test
Special notes for your reviewer:
Additional documentation or context
Test Pass in
v1.7.2-rc1