Skip to content

Conversation

@nasimafeef
Copy link
Contributor

No description provided.

@nasimafeef nasimafeef merged commit fc42ba7 into master-sq-temp Sep 25, 2019
@nasimafeef nasimafeef deleted the bugfix/undefined-facebook branch September 25, 2019 11:15
@ChangXiaoning
Copy link

Hi, I am a Node.js learner. I am curious about the reason why facebook is undefined. Look forward for your reply. Thx.

@ramizbalayil
Copy link
Contributor

Hi, I am a Node.js learner. I am curious about the reason why facebook is undefined. Look forward for your reply. Thx.

Hi @ChangXiaoning ,
Facebook is a class in our game project. And changing names of the classes will give undefined in this case.

Two of our games use the same repository as submodule and they are both directed to two different commit hash. Unlike the current master branch, initially, there were a lot of game related classes being used in the module and our first game is still directed to that commit. This has been fixed in the current master branch.

@ChangXiaoning
Copy link

Hi, I am a Node.js learner. I am curious about the reason why facebook is undefined. Look forward for your reply. Thx.

Hi @ChangXiaoning ,
Facebook is a class in our game project. And changing names of the classes will give undefined in this case.

Two of our games use the same repository as submodule and they are both directed to two different commit hash. Unlike the current master branch, initially, there were a lot of game related classes being used in the module and our first game is still directed to that commit. This has been fixed in the current master branch.

Thx for your replay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants