Skip to content

Add the FORM package#619

Merged
ahmadia merged 3 commits intomasterfrom
form
Feb 14, 2015
Merged

Add the FORM package#619
ahmadia merged 3 commits intomasterfrom
form

Conversation

@certik
Copy link
Copy Markdown
Member

@certik certik commented Feb 6, 2015

No description provided.

@ahmadia
Copy link
Copy Markdown
Contributor

ahmadia commented Feb 7, 2015

This has an unspecified dependency on autotools being installed, but I'm okay with merging it if you need it.

@certik
Copy link
Copy Markdown
Member Author

certik commented Feb 8, 2015

Let's get it fixed properly. It has:

extends: [autotools_package]

so it is depending on autotools implicitly. Do you think there is a problem somewhere?

@ahmadia
Copy link
Copy Markdown
Contributor

ahmadia commented Feb 8, 2015

autotools_package means that it uses a ./configure && make && make install style of build. Release packages typically provide a pre-built configure script (created by autotools on the packager's machine). When you're working from a repository, however, you typically need to bootstrap the configure script yourself, using a tool like autoconf. In the build script, you're calling autoreconf, which is the full smorgasbord of autotools/automake/libtools builders, so you're implicitly depending on those being available on the hashdist user's system.

@ahmadia
Copy link
Copy Markdown
Contributor

ahmadia commented Feb 8, 2015

It's not a problem for me, I'm not using this package, but it might be a problem for you :)

@jcftang
Copy link
Copy Markdown
Member

jcftang commented Feb 10, 2015

You could depend on the autotools that are in hashdist, but it's a lot to be asking for users to install autotools from hashdist to build a package. The autotools packages are a bit fragile at the moment.

So that the autoreconf is used from Hashstack.
@certik
Copy link
Copy Markdown
Member Author

certik commented Feb 10, 2015

Another package that has the same problem is "mesa".

So what's the solution? Upstream does not provide the configure file, so we need to use our own autotools to rebuild it. @jcftang did you mean 2fd6cff is too much to ask, or that without this patch it is too much to ask?

@jcftang
Copy link
Copy Markdown
Member

jcftang commented Feb 10, 2015

@certik if its just autoconf and or automake I think it would be fine, I think I miss understood that autotools does not include autogen.

@certik
Copy link
Copy Markdown
Member Author

certik commented Feb 10, 2015

I need to test it on some system without autoreconf installed (so far I only tested on my RHEL6 machine that already has autoreconf installed), but I think 2fd6cff should fix the problem.

@certik
Copy link
Copy Markdown
Member Author

certik commented Feb 13, 2015

So it turns out I need autoconf and automake, now things build out of the box. No problem at all.

Except a minor problem on my laptop that autotools itself doesn't build, but I fixed that in #631. The actual local test that I did was that I merged #631 with this PR and only then tested FORM and it works.

Let me know if you have any further feedback regarding this PR.

@ahmadia
Copy link
Copy Markdown
Contributor

ahmadia commented Feb 13, 2015

In the future you may also need libtool, I believe.

@certik
Copy link
Copy Markdown
Member Author

certik commented Feb 14, 2015

@ahmadia what do you think might be needed from libtool? I uninstalled libtool from my Ubuntu and rebuilt FORM --- no problem at all.

Let me know if this PR is ok to merge.

@ahmadia
Copy link
Copy Markdown
Contributor

ahmadia commented Feb 14, 2015

Yeah, I just checked this locally. libtool isn't needed by form, it's just something that needed to be explicitly verified in their configure.ac.

@ahmadia
Copy link
Copy Markdown
Contributor

ahmadia commented Feb 14, 2015

This is all good.

ahmadia added a commit that referenced this pull request Feb 14, 2015
@ahmadia ahmadia merged commit 81ec45b into master Feb 14, 2015
@ahmadia ahmadia deleted the form branch February 14, 2015 17:17
@certik
Copy link
Copy Markdown
Member Author

certik commented Feb 15, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants