Skip to content

update IPython to 3.1#751

Merged
certik merged 2 commits intohashdist:masterfrom
minrk:ipython-3.1
May 10, 2015
Merged

update IPython to 3.1#751
certik merged 2 commits intohashdist:masterfrom
minrk:ipython-3.1

Conversation

@minrk
Copy link
Copy Markdown
Contributor

@minrk minrk commented May 2, 2015

  • add missing dependency on markupsafe to jinja2
  • add missing dependency on jsonschema to ipython
  • update tornado to 4.1 (required for IPython 3)
  • add backports.ssl_match_hostname (required for tornado 4)

@certik
Copy link
Copy Markdown
Member

certik commented May 3, 2015

Tests failed for jinja2. It needs to be investigated.

- add missing dependency on markupsafe to jinja2
- add missing dependency on jsonschema to ipython
- update tornado to 4.1 (required for IPython 3)
- add backports.ssl_match_hostname (required for tornado 4)
@minrk
Copy link
Copy Markdown
Contributor Author

minrk commented May 4, 2015

jinja2 yaml seems to have needed a newline that other yaml files don't have. Weird.

@ahmadia
Copy link
Copy Markdown
Contributor

ahmadia commented May 4, 2015

Hi, a bit late to the party, but a bunch of this work was already done in the private ROAMS stack...

@certik
Copy link
Copy Markdown
Member

certik commented May 4, 2015

I don't know what ROAMS is, but you should opensource more of your private work. :)

@cekees
Copy link
Copy Markdown
Contributor

cekees commented May 4, 2015

We're trying... The overlap here is not quite duplication. What minrk is
pushing is for the actual IPython 3.1.0 release whereas the private
repository was based on dev branches and forks of the official work that
wasn't ready for the public hashstack. I'm working to minimize the number
of packages that aren't coming directly from hashstack master or at least
a branch of hashstack.

On Mon, May 4, 2015 at 3:24 PM, Ondřej Čertík notifications@github.com
wrote:

I don't know what ROAMS is, but you should opensource more of your private
work. :)


Reply to this email directly or view it on GitHub
#751 (comment).

@cekees
Copy link
Copy Markdown
Contributor

cekees commented May 8, 2015

I've tested this on ubuntu on several HPC machines. I'm fine with it going into master.

Comment thread pkgs/backports-ssl_match_hostname.yaml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependencies section can be removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@certik
Copy link
Copy Markdown
Member

certik commented May 9, 2015

Only a minor comment above. +1 to merge.

certik added a commit that referenced this pull request May 10, 2015
@certik certik merged commit d733abf into hashdist:master May 10, 2015
@certik
Copy link
Copy Markdown
Member

certik commented May 10, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants