Feature/role base access control

[amatsonkali]

No description provided.

[sebastianmontero]

Looks good to me! Pending the pallet_id solution.

[sebastianmontero]

I think it would be good to handle the pallet_name/pallet_id parameter as an enum, that can be either the pallet_name or the pallet_id(the hashed pallet name), this enum could have to functions:

• to_id_enum() that returns the enum that contains a pallet_id
• to_id() that returns the actual pallet_id
  This would enable:
• the encapsulation of all the logic related to this parameter in a type
• the hashing of the name only once in cases where a function that receives this parameter calls multiple other functions that also receives this parameter

What do you think?

[amatsonkali]

Interesting solution, I developed a similar solution for role name or role id, but I discarded it because it adds some development complexity, I'll try that out again

[amatsonkali]

How does this implementation look? I'm going to test this enum out

#[derive(Encode, Decode, Clone, Eq, PartialEq,)]
pub enum IdOrVec{
    Id([u8;32]),
    Vec(Vec<u8>)
}

impl IdOrVec{
    pub fn to_id_enum(&self)->Self{
        match self{
            Self::Id(_) => self.clone(),
            Self::Vec(_) => Self::Id(Self::to_id(&self))
        }
    }

    pub fn to_id(&self)->[u8;32]{
        match self{
            Self::Id(id) => id.clone(),
            Self::Vec(v) => v.clone().using_encoded(blake2_256)
        }
    }
}

[sebastianmontero]

It looks good!

[didiermis]

LGTM