Add Custom CA Bundle configuration #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewbankkit
approved these changes
Feb 17, 2022
Collaborator
ewbankkit
left a comment
ewbankkit
left a comment
There was a problem hiding this comment.
LGTM 🚀.
% make test
go test -timeout=30s -parallel=4 ./...
ok github.com/hashicorp/aws-sdk-go-base/v2 2.681s
? github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/config [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/constants [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/internal/expand 1.381s
? github.com/hashicorp/aws-sdk-go-base/v2/internal/test [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/mockdata [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/servicemocks [no test files]
cd v2/awsv1shim && go test -timeout=30s -parallel=4 ./...
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2 1.721s
? github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/mockdata [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr (cached)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
CustomCABundleconfiguration parameter and adds tests for configuring with environment variable.The AWS SDK v1 shim now creates its own HTTP client with equivalent configuration, since wrappers used in the V2 client cause an error.
Closes #119
Relates hashicorp/terraform-provider-aws#23224