Enable additional golangci-lint linters and fix reports #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously:
```
$ make lint
awsauth_test.go:127:32: Using the variable on range scope `testCase` in function literal (scopelint)
awsTs := awsMetadataApiMock(testCase.EC2MetadataEndpoints)
^
awsauth_test.go:130:60: Using the variable on range scope `testCase` in function literal (scopelint)
closeIam, iamSess, err := GetMockedAwsApiSession("IAM", testCase.IAMEndpoints)
^
awsauth_test.go:136:60: Using the variable on range scope `testCase` in function literal (scopelint)
closeSts, stsSess, err := GetMockedAwsApiSession("STS", testCase.STSEndpoints)
^
awsauth_test.go:145:76: Using the variable on range scope `testCase` in function literal (scopelint)
accountID, partition, err := GetAccountIDAndPartition(iamConn, stsConn, testCase.AuthProviderName)
^
awsauth_test.go:146:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err != nil && testCase.ErrCount == 0 {
^
awsauth_test.go:149:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err == nil && testCase.ErrCount > 0 {
^
awsauth_test.go:150:53: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Expected %d error(s), received none", testCase.ErrCount)
^
awsauth_test.go:152:20: Using the variable on range scope `testCase` in function literal (scopelint)
if accountID != testCase.ExpectedAccountID {
^
awsauth_test.go:153:85: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed account ID doesn't match with expected (%q != %q)", accountID, testCase.ExpectedAccountID)
^
awsauth_test.go:155:20: Using the variable on range scope `testCase` in function literal (scopelint)
if partition != testCase.ExpectedPartition {
^
awsauth_test.go:156:84: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed partition doesn't match with expected (%q != %q)", partition, testCase.ExpectedPartition)
^
awsauth_test.go:227:60: Using the variable on range scope `testCase` in function literal (scopelint)
closeIam, iamSess, err := GetMockedAwsApiSession("IAM", testCase.MockEndpoints)
^
awsauth_test.go:236:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err != nil && testCase.ErrCount == 0 {
^
awsauth_test.go:239:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err == nil && testCase.ErrCount > 0 {
^
awsauth_test.go:240:53: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Expected %d error(s), received none", testCase.ErrCount)
^
awsauth_test.go:242:20: Using the variable on range scope `testCase` in function literal (scopelint)
if accountID != testCase.ExpectedAccountID {
^
awsauth_test.go:243:85: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed account ID doesn't match with expected (%q != %q)", accountID, testCase.ExpectedAccountID)
^
awsauth_test.go:245:20: Using the variable on range scope `testCase` in function literal (scopelint)
if partition != testCase.ExpectedPartition {
^
awsauth_test.go:246:84: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed partition doesn't match with expected (%q != %q)", partition, testCase.ExpectedPartition)
^
awsauth_test.go:285:60: Using the variable on range scope `testCase` in function literal (scopelint)
closeIam, iamSess, err := GetMockedAwsApiSession("IAM", testCase.MockEndpoints)
^
awsauth_test.go:294:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err != nil && testCase.ErrCount == 0 {
^
awsauth_test.go:297:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err == nil && testCase.ErrCount > 0 {
^
awsauth_test.go:298:53: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Expected %d error(s), received none", testCase.ErrCount)
^
awsauth_test.go:300:20: Using the variable on range scope `testCase` in function literal (scopelint)
if accountID != testCase.ExpectedAccountID {
^
awsauth_test.go:301:85: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed account ID doesn't match with expected (%q != %q)", accountID, testCase.ExpectedAccountID)
^
awsauth_test.go:303:20: Using the variable on range scope `testCase` in function literal (scopelint)
if partition != testCase.ExpectedPartition {
^
awsauth_test.go:304:84: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed partition doesn't match with expected (%q != %q)", partition, testCase.ExpectedPartition)
^
awsauth_test.go:343:60: Using the variable on range scope `testCase` in function literal (scopelint)
closeSts, stsSess, err := GetMockedAwsApiSession("STS", testCase.MockEndpoints)
^
awsauth_test.go:352:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err != nil && testCase.ErrCount == 0 {
^
awsauth_test.go:355:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err == nil && testCase.ErrCount > 0 {
^
awsauth_test.go:356:53: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Expected %d error(s), received none", testCase.ErrCount)
^
awsauth_test.go:358:20: Using the variable on range scope `testCase` in function literal (scopelint)
if accountID != testCase.ExpectedAccountID {
^
awsauth_test.go:359:85: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed account ID doesn't match with expected (%q != %q)", accountID, testCase.ExpectedAccountID)
^
awsauth_test.go:361:20: Using the variable on range scope `testCase` in function literal (scopelint)
if partition != testCase.ExpectedPartition {
^
awsauth_test.go:362:84: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed partition doesn't match with expected (%q != %q)", partition, testCase.ExpectedPartition)
^
awsauth_test.go:403:67: Using the variable on range scope `testCase` in function literal (scopelint)
accountID, partition, err := parseAccountIDAndPartitionFromARN(testCase.InputARN)
^
awsauth_test.go:404:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err != nil && testCase.ErrCount == 0 {
^
awsauth_test.go:407:21: Using the variable on range scope `testCase` in function literal (scopelint)
if err == nil && testCase.ErrCount > 0 {
^
awsauth_test.go:408:70: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Expected %d error(s) when parsing ARN, received none", testCase.ErrCount)
^
awsauth_test.go:410:20: Using the variable on range scope `testCase` in function literal (scopelint)
if accountID != testCase.ExpectedAccountID {
^
awsauth_test.go:411:85: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed account ID doesn't match with expected (%q != %q)", accountID, testCase.ExpectedAccountID)
^
awsauth_test.go:413:20: Using the variable on range scope `testCase` in function literal (scopelint)
if partition != testCase.ExpectedPartition {
^
awsauth_test.go:414:84: Using the variable on range scope `testCase` in function literal (scopelint)
t.Fatalf("Parsed partition doesn't match with expected (%q != %q)", partition, testCase.ExpectedPartition)
^
awserr_test.go:107:20: Using the variable on range scope `testCase` in function literal (scopelint)
got := IsAWSErr(testCase.Err, testCase.Code, testCase.Message)
^
awserr_test.go:109:14: Using the variable on range scope `testCase` in function literal (scopelint)
if got != testCase.Expected {
^
awserr_test.go:110:42: Using the variable on range scope `testCase` in function literal (scopelint)
t.Errorf("got %t, expected %t", got, testCase.Expected)
^
awserr_test.go:333:28: Using the variable on range scope `testCase` in function literal (scopelint)
got := IsAWSErrExtended(testCase.Err, testCase.Code, testCase.Message, testCase.ExtendedMessage)
^
awserr_test.go:335:14: Using the variable on range scope `testCase` in function literal (scopelint)
if got != testCase.Expected {
^
awserr_test.go:336:42: Using the variable on range scope `testCase` in function literal (scopelint)
t.Errorf("got %t, expected %t", got, testCase.Expected)
^
session_test.go:34:35: Using the variable on range scope `tc` in function literal (scopelint)
opts, err := GetSessionOptions(tc.config)
^
awsauth_test.go:735:20: `invalidAwsEnv` - `t` is unused (unparam)
func invalidAwsEnv(t *testing.T) func() {
^
mock.go:22:18: mnd: Magic number: 500, in <argument> detected (gomnd)
w.WriteHeader(500)
^
mock.go:46:17: mnd: Magic number: 400, in <argument> detected (gomnd)
w.WriteHeader(400)
^
mock.go:83:17: mnd: Magic number: 400, in <argument> detected (gomnd)
w.WriteHeader(400)
^
session.go:87:21: mnd: Magic number: 9, in <condition> detected (gomnd)
if r.RetryCount < 9 {
^
awsauth.go:241:19: mnd: Magic number: 100, in <operation> detected (gomnd)
client.Timeout = 100 * time.Millisecond
^
make: *** [lint] Error 1
```
anGie44
approved these changes
Jun 1, 2020
Contributor
anGie44
left a comment
anGie44
left a comment
There was a problem hiding this comment.
LGTM (though can't say I'm tooo familiar with the list of added linters 😅 ) and linter/tests are passing as expected 👍
| func invalidAwsEnv(t *testing.T) func() { | ||
| func invalidAwsEnv() func() { | ||
| ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.WriteHeader(400) |
Contributor
There was a problem hiding this comment.
just a general linter q: noticed this line wasn't caught by the linter like in mock.go, is this expected? thought maybe it was b/c it's embedded within another function or in general test cases are ignored?
Contributor
Author
There was a problem hiding this comment.
It looks like https://github.com/tommy-muehle/go-mnd ignores test files by default. 👍 I'm not sure if there's a way to enable that.
Contributor
There was a problem hiding this comment.
ahh i see makes sense, the config object is hardcoded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Previously: